Comparing coreutils:master...pixelb:i18n · coreutils/coreutils · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: coreutils/coreutils
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: pixelb/coreutils
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: i18n
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 22 files changed
  • 1 contributor

Commits on Nov 5, 2015

  1. all: initial snapshot of LI18NUX derived patch 

    Note the gnulib component is at gl/lib/linebuffer.h.diff
and will need to have the paths adjusted in a generated patch.
    @pixelb
    pixelb committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    2a2f58c View commit details
    Browse the repository at this point in the history

  2. sort: fix buffer overflow with some case conversions 

    * src/sort.c (keycompare_mb): Ensure the buffer is big enough
to handle anything output from wctomb().  The current implementation
is character based, so we allocate the worst case size for the
conversion buffer, which is MB_CUR_MAX for each input byte.
* tests/i18n/sort.sh: Add a test case causing seg fault.
* tests/local.mk: Reference the new test case.
Reported at https://bugzilla.suse.com/show_bug.cgi?id=928749
    @pixelb
    pixelb committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    b9796f3 View commit details
    Browse the repository at this point in the history

  3. sort: fix large mem leak with --month-sort 

    * src/sort.c (getmonth_mb): free() the originally
malloced pointers, rather than the pointers passed
to the conversion functions, as those pointers are
reset to NULL upon successful conversion.
* tests/i18n/sort-month.sh: Add a new test.
* tests/local.mk: Reference new test.
    @pixelb
    pixelb committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    03c5eb3 View commit details
    Browse the repository at this point in the history

  4. sort: fix assertion with some inputs to --month-sort 

    * src/sort.c (getmonth_mb): Ensure the buffer is big enough
for wcsrtombs() even when the upper case representation
uses more space than the lower case.
* tests/i18n/sort-month.sh: Adjust the test case accordingly.
    @pixelb
    pixelb committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    569d0d7 View commit details
    Browse the repository at this point in the history
Loading