This is how every other static analysis tool for every language out there works today.

clang-tidy, clang-format, eslint, phpstan, psalm, sonar lint, clippy, etc.

It causes no harm to anyone working on the codebase not using those tools (although I would argue if a project is using static analysis tools, then every engineer working on it should also be using those tools), and gives engineers using them the capability to suppress false-positives when they come up.

I'd argue that those tools are integral to a project, where as the IDE you are using is a developer choice. Phpactor's diagnostics are primarily to draw attention to problems fixable with code actions. It is not there to prove the correctness of your code.

You can disable Phpactor's diagnostics, specifically or globally and depend on f.e. the PHPStan integration while still benefiting from code actions.

So I'd be disinclined to introduce an /** @phpactor-ignore */ annotation, because Phpactors diagnostics should never be blocking and I'd personally not see /** @phpstactor-ignore @phpstan-ignore-next-line @psalm-surpress */ if that would even work 😅

So I'd be disinclined to introduce an /** @phpactor-ignore / annotation, because Phpactors diagnostics should never be blocking and I'd personally not see /* @phpstactor-ignore @phpstan-ignore-next-line @psalm-surpress */ if that would even work 😅

Yeah this is not about phpactor diagnostics being blocking/nonblocking w.r.t. to code review, CI or anything like that, nor is it about using phpactor's diagnostics to prove correctness, and disabling a single diagnostic (or all diagnostics) globally is not the right solution either, because just because a particular diagnostic is a false positive in one specific location does not mean it should be disabled across the board.

The goal here is to be able to suppress specific isolated occurrences so that when someone using phpactor in the project sees a red/orange squiggly, they know it's something they should actually look at, and similarly, don't waste time looking at a diagnostic that isn't correct (because it has been suppressed with the hypothetical annotation).