{{ message }}
Repository navigation
Breaking change! #30
Description
Hello, in the #21 there is a breaking change!
Many projects use the standalone version of PHPstan without using Composer.
But with changes that were made in #21 the default value of version is changed to composer and it's a breaking change!
Because many CIs relied on this and it was broken now!
I think it should be published under a new version!
Or, using a fallback strategy to fix this.
Activity
[-]Breaking change made![/-][+]Breaking change![/+]g105b commentedon Dec 12, 2024
Hi @hosni thank you for reporting this.
You are completely correct! I appologise for this oversight.
What course of action do you think it the most appropriate? Should I recall the changes to the latest rolling release, and make a new stable release version, or do you think it would cause more issues in altering the existing release?
hosni commentedon Dec 15, 2024
Hi @g105b thank for your great job here.
I think it's better to just change the default value of the
versioninput to it's previous value (latest), and keep the changes still remain.There is no need to revert whole PR, just changing the default value is enough.
And in the next major version, change it back again to
composer.Anything missed?
g105b commentedon Dec 19, 2024
I think that's the best approach. I will make this change today, and mark the change to be made for the next version. Thanks for you insight.
phpstan, with version
Composer update and handle failed json encode (#44)
AniLeo commentedon Feb 8, 2025
I can currently reproduce this issue with the following CI file: https://github.com/AniLeo/rpcs3-compatibility/blob/master/.github/workflows/master.yml
I have worked around the issue by specifying
version: latest