Code won't compile after Markdown Javadoc is formatted · Issue #1803 · palantir/palantir-java-format · GitHub
Skip to content

Code won't compile after Markdown Javadoc is formatted #1803

Open
openjavaformat/open-java-format
#102

Description

@DamianFekete

This class

public class Xxx {

    /// @param a A
    /// @param b Aaaaaaa aaaaaaaaaa aaaaaaaaaaaaa aaaaaa aaaaaaaaaaaaaa aaaaaaaaa, aaaaaa aaaaaaaaa (aaaaaaaa XXXXXXXX aaaaaaa)
    public record Yyy(String a, String b) {}

    /// X
    /// * aaaaaaa aaaa aaaa aaa aa aaa aaaaaa aa aaaa aaaaaaaa aaaaaaa aaaaa aaaaaaaaaaaaaaaaaa aa aaaa aa aa XXXXXXX
    String x;
}

is formatted like this by the IntelliJ palantir-java-format 2.100.0 plugin.

public class Xxx {

    /// @param a A
    /// @param b Aaaaaaa aaaaaaaaaa aaaaaaaaaaaaa aaaaaa aaaaaaaaaaaaaa aaaaaaaaa, aaaaaa aaaaaaaaa (aaaaaaaa
    XXXXXXXX aaaaaaa)
    public record Yyy(String a, String b) {}

    /// X
    /// * aaaaaaa aaaa aaaa aaa aa aaa aaaaaa aa aaaa aaaaaaaa aaaaaaa aaaaa aaaaaaaaaaaaaaaaaa aa aaaa aa aa
    XXXXXXX
    String x;
}

Spotless 3.10.3 "crashes" (mvn -X spotless:apply):

[ERROR] Step 'removeUnusedImports' found problem in 'Xxx.java':
7:21: error: ';' expected
com.google.googlejavaformat.java.FormatterException: 7:21: error: ';' expected
    at com.google.googlejavaformat.java.FormatterException.fromJavacDiagnostics (FormatterException.java:56)
    at com.google.googlejavaformat.java.RemoveUnusedImports.parse (RemoveUnusedImports.java:225)
    at com.google.googlejavaformat.java.RemoveUnusedImports.removeUnusedImports (RemoveUnusedImports.java:207)
    at com.diffplug.spotless.glue.java.GoogleJavaFormatRemoveUnusedImporterFormatterFunc.apply (GoogleJavaFormatRemoveUnusedImporterFormatterFunc.java:38)
    at com.diffplug.spotless.FormatterFunc.apply (FormatterFunc.java:33)
    at com.diffplug.spotless.FormatterStepEqualityOnStateSerialization.format (FormatterStepEqualityOnStateSerialization.java:51)
    at com.diffplug.spotless.Formatter.computeWithLint (Formatter.java:172)
    at com.diffplug.spotless.Formatter.compute (Formatter.java:137)
    at com.diffplug.spotless.generic.FenceStep$BaseFormatter.applyWithFile (FenceStep.java:226)
    at com.diffplug.spotless.FormatterFunc$NeedsFile.apply (FormatterFunc.java:174)
    at com.diffplug.spotless.FormatterStepEqualityOnStateSerialization.format (FormatterStepEqualityOnStateSerialization.java:51)
    at com.diffplug.spotless.Formatter.computeWithLint (Formatter.java:172)
    at com.diffplug.spotless.DirtyState.of (DirtyState.java:96)
    at com.diffplug.spotless.LintState.of (LintState.java:140)
    at com.diffplug.spotless.LintState.of (LintState.java:134)
    at com.diffplug.spotless.maven.AbstractSpotlessMojo.calculateLintState (AbstractSpotlessMojo.java:253)
    at com.diffplug.spotless.maven.SpotlessApplyMojo.process (SpotlessApplyMojo.java:79)
    at com.diffplug.spotless.maven.AbstractSpotlessMojo.execute (AbstractSpotlessMojo.java:287)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)

May or may not be related to #1776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions