Tag 'linter-like' quality queries that don't use pointsto · osanben/codeql@4b1d31c · GitHub
Skip to content

Commit 4b1d31c

Browse files
joefarebrotherjoefarebrother
committed
Tag 'linter-like' quality queries that don't use pointsto
1 parent 869e33e commit 4b1d31c

14 files changed

Lines changed: 32 additions & 17 deletions

‎python/ql/src/Imports/ImportandImportFrom.ql‎

Lines changed: 3 additions & 1 deletion

‎python/ql/src/Imports/ModuleImportsItself.ql‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
* @name Module imports itself
33
* @description A module imports itself
44
* @kind problem
5-
* @tags maintainability
5+
* @tags quality
6+
* maintainability
67
* useless-code
78
* @problem.severity recommendation
89
* @sub-severity high

‎python/ql/src/Imports/MultipleImports.ql‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
* @name Module is imported more than once
33
* @description Importing a module a second time has no effect and impairs readability
44
* @kind problem
5-
* @tags maintainability
5+
* @tags quality
6+
* maintainability
67
* useless-code
78
* @problem.severity recommendation
89
* @sub-severity high

‎python/ql/src/Imports/UnintentionalImport.ql‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,9 @@
33
* @description Importing a module using 'import *' may unintentionally pollute the global
44
* namespace if the module does not define `__all__`
55
* @kind problem
6-
* @tags maintainability
7-
* modularity
6+
* @tags quality
7+
* maintainability
8+
* readability
89
* @problem.severity recommendation
910
* @sub-severity high
1011
* @precision very-high

‎python/ql/src/Imports/UnusedImport.ql‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
* @name Unused import
33
* @description Import is not required as it is not used
44
* @kind problem
5-
* @tags maintainability
5+
* @tags quality
6+
* maintainability
67
* useless-code
78
* @problem.severity recommendation
89
* @sub-severity high

‎python/ql/src/Statements/AssertOnTuple.ql‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22
* @name Asserting a tuple
33
* @description Using an assert statement to test a tuple provides no validity checking.
44
* @kind problem
5-
* @tags reliability
6-
* maintainability
5+
* @tags quality
6+
* reliability
7+
* correctness
78
* external/cwe/cwe-670
89
* @problem.severity error
910
* @sub-severity low

‎python/ql/src/Statements/ConstantInConditional.ql‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
* @name Constant in conditional expression or statement
33
* @description The conditional is always true or always false
44
* @kind problem
5-
* @tags maintainability
5+
* @tags quality
6+
* maintainability
67
* useless-code
78
* external/cwe/cwe-561
89
* external/cwe/cwe-570

‎python/ql/src/Statements/NestedLoopsSameVariable.ql‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,9 @@
33
* @description Nested loops in which the target variable is the same for each loop make
44
* the behavior of the loops difficult to understand.
55
* @kind problem
6-
* @tags maintainability
7-
* correctness
6+
* @tags quality
7+
* maintainability
8+
* readability
89
* @problem.severity recommendation
910
* @sub-severity high
1011
* @precision very-high

‎python/ql/src/Statements/NestedLoopsSameVariableWithReuse.ql‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
* @description Redefining a variable in an inner loop and then using
44
* the variable in an outer loop causes unexpected behavior.
55
* @kind problem
6-
* @tags maintainability
6+
* @tags quality
7+
* reliability
78
* correctness
89
* @problem.severity error
910
* @sub-severity low

‎python/ql/src/Statements/RedundantAssignment.ql‎

Lines changed: 2 additions & 1 deletion

0 commit comments

Comments
 (0)