{{ message }}
GitHub Community
Comment forms have become unusable #199037
Unanswered
gibson042
asked this question in
Accessibility
Replies: 1 comment
-
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
🏷️ Discussion Type
Bug
💬 Feature/Topic Area
Other
Body
On a normal issue or PR page, typing in a comment textarea incurs a lag on each keystroke that is not just noticeable but actually experience-degrading to such a degree that I now find myself typing in the browser location bar to copy-and-paste in the comment form.
I did some digging, and processing a typical keystroke on my oldest machine looks something like
onKeyDownfunction from GlobalCommands.tsx about 20 times, each of which spends 45% of its time inquerySelectorAlland 55% inelementHasNonZeroHeight, both viagetActiveModalfrom utils.ts), and thenupdateTextareain react-dom-client.production.js prompts a very deep stack of functions likerecursivelyTraverseMutationEffects/recursivelyTraverseDeletionEffects/commitDeletionEffectsOnFiber/commitMutationEffectsOnFiberthat ultimately ends up removing an octicon from the issue close button ashostParent.removeChild1, cascading into a ~60 millisecond re-layout operation for each keypress that in most cases isn't even necessary becauseinsertOrAppendPlacementNodeadds back another one just like it anyway).Footnotes
which notably isn't directly native but rather overridden in remove-child-patch.ts ↩
Beta Was this translation helpful? Give feedback.
All reactions