Improved pull request "Files Changed" experience feedback #163932
Replies: 3221 comments 1330 replies
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
|
It doesn't always seem to remember if hide whitespace was turned on. |
|
Our project |
|
I need to be able to copy the entire file contents |
Sure but it's no longer dockable on the left so I can use it to navigate large PRs? Ugh, pass. goes back to classic view |
|
Please, please, please provide a way to toggle "View/Viewed" for all files. I frequently go through all the files and mark them as viewed and then it's a hassle to go back and re-review. |
Review threads on non-ASCII file paths are not rendered in Files changedReproduced by two users in different browsers. Both experiences are affected, each with a different symptom. Setup
What breaksOnly the 4 threads in the umlaut files.
In the new experience there is no comment badge in the sidebar tree and no thread in the diff, as if the comments did not exist. The stored data is correct
So the mismatch happens in the frontend, not in the stored data. Also in the new experience
Reproduction
ImpactA reviewer opening Files changed does not see all comments, so findings get missed and code goes in unreviewed. Non-ASCII paths are normal outside English-language codebases, which is probably why this has not surfaced more widely. |
|
Please add a setting to always expand code review comments. Finding, reading and addressing code review comments is a core functionality of the Github application, so hiding them generates a pointlessly challenging code review experience. Also there should be a way to navigate from a code review comment viewed on the "Conversation" tab to the same expanded comment on the "Files" tab. Not related (other than to the design philosophy of auto-hiding information required for code review), but allowing us to set an "auto-collapse diffs over X lines" setting would be very useful. The current threshold seems to be a few hundred lines, which is way too small and makes searching for identifiers in the files tab annoying. (Alternatively, add a "search in diff" feature.) |
|
A "Unable to load page" error occurs when switching from the "Files changed" tab to the "Conversation" tab. |
|
This looks like the same issue as https://github.com/orgs/community/discussions/163932#discussioncomment-18235905 (umlaut paths), reproduced here with Korean (Hangul) file paths. Submitted inline review threads on non-ASCII paths are not rendered in the new "Files changed" page. Repro (same PR, same review, same settings):
Tried: "Minimize comments" off, pressing i, Split/Unified, hard reload, "Jump to the comment in the diff" from the Comments panel (URL changes to #r, nothing renders). The Comments side panel lists the threads correctly. Classic page (feature preview disabled, or logged out) renders them fine. The "Perf Experiment" toggle makes no difference. For now I've switched back to the classic page. Is this on your radar, and is there a rough timeline for a fix? Our RFC docs all have Korean file names, so every RFC review hits this. Screenshots: (1) PR #123, ASCII path, thread rendered (2) PR #123, Korean path line 104, nothing rendered (3) PR #127, Comments panel lists 8 threads while the diff shows none, Minimize comments unchecked (4) PR #127 on the classic page (feature preview disabled), same Korean-path file, thread rendered under line 14 |
|
|
I've found it's become really hard to spot comments when looking at file changes now — even when I know more or less where I'm looking for one. |





























Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
✨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ Updates
See what's been fixed and improved since the launch of the public preview:
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
All reactions