GitHub Community
"Colorblind themes" Did "Dark Protanopia & Deuteranopia" change recently #149256
-
Beta Was this translation helpful? Give feedback.
Replies: 7 comments 5 replies
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
-
|
Seconding this. This seems to be connected to the Feature Preview ("Colorblind themes"). I seemingly was switched over to the "dark Protanopia & Deuteranopia" combined color scheme. However, I noticed that this change suddenly (since I wasn't aware of it) made it hard for me to tell which issue is closed or opened. The colours for closed/open are indistinguishable for me and the icons aren't enough of an indicator (partially due to old habits, partially because it looks like the "Closed" color to me that I remember) |
Beta Was this translation helpful? Give feedback.
-
|
Depending on the severity of the colorblindness, someone else might find the old colors problematic, but the new ones are almost certainly less distinguishable for a large amount of the people that this color theme was made for.
|
Beta Was this translation helpful? Give feedback.
-
|
i believe they used to be orange/blue… now they're almost exactly the same shade of purple! if you have the old colors on hand you could probably make a custom css to replace them back (and maybe i will eventually) |
Beta Was this translation helpful? Give feedback.
-
|
Hello @glennj - thank you for your feedback on the colorblind-focused themes. We've made some recent updates and would like to follow up on your reported bug. Could you let us know if this issue is still occurring for you? |
Beta Was this translation helpful? Give feedback.
-
|
Looks better. Thanks. |
Beta Was this translation helpful? Give feedback.
-
|
I think the colours here have suddenly changed again? I've noticed this, since I associate the "merged" status with this blue colour that open PRs have now changed to again.
While the conflict between colours is now less severe (overlap between merged/success & cancelled/closed, presumably), it does again change the associated colour of the merged status, but also removes one level of distinction again, which might be a little unfortunate |
Beta Was this translation helpful? Give feedback.
-
|
@cehfisher did this get reverted? |
Beta Was this translation helpful? Give feedback.
-
|
Hi @glennj – could you retest this when you have a chance? I believe the design team recently updated the Dark Protanopia and Deuteranopia theme colors. I just want to make sure everything still looks good on your end and that the differences are still distinguishable by both shape and color. Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
I see:
The colours are distinct, and the shape of an issue (circular) vs a PR (branches) is helpful. Red seems an odd colour for an actionable item, but if that's where the research took you, I can adapt. Is this work documented anywhere? |
Beta Was this translation helpful? Give feedback.
-
|
Hi @glennj – I searched the GitHub changelog and didn't see anything related to updates to the dark Protanopia and Deuteranopia themes. I did, however, find an update to the Primer primitives that introduced high-contrast versions of several themes, including the colorblindness-focused themes: primer/primitives#1190 I'm wondering if that is when the changes that @kitten reported were introduced. I can't say for sure whether the current behavior is intentional, but we can always check back with the design team to see if this was a planned change or an unintended reversion. If this was a deliberate update, what would you have expected to see instead? Any additional context on what feels off would help us provide more useful feedback to the design team. On the other hand, if the updated icons address your concerns and the current colors seem to be working well, feel free to close out this thread. Thanks! |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
Hello @glennj – a quick follow-up. I talked to the a11y design team and they located this issue you found and created a patch to fix it. It will roll-out on the next Primer update. I don't have an ETA on when that will be, but will check back in when I hear more. Thanks again for all your help!