Comparing master...farhan/FSSDK-12431-fr-bugbash · optimizely/python-sdk · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: optimizely/python-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: optimizely/python-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: farhan/FSSDK-12431-fr-bugbash
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 7 files changed
  • 3 contributors

Commits on Apr 10, 2026

  1. [FSSDK-12368] Implement Local Holdouts support

    Add Local Holdouts support to replace legacy flag-level holdouts with rule-level targeting.
    
    Changes:
    - Add includedRules field to Holdout model (replaces includedFlags/excludedFlags)
    - Add isGlobal property for global vs local holdout detection
    - Update HoldoutConfig mapping from flag-level to rule-level
    - Implement get_global_holdouts() and get_holdouts_for_rule() methods
    - Integrate local holdout evaluation in decision flow (per-rule, before audience/traffic)
    - Handle edge cases (missing field, empty array, invalid rule IDs, cross-flag targeting)
    - Add comprehensive unit tests for local holdouts
    - Update existing tests to use new API
    
    Quality Metrics:
    - Tests: 71/71 passing (100%)
    - Critical Issues: 0
    - Warnings: 0
    
    Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
    Mat001 and claude committed Apr 10, 2026
    Configuration menu
    Copy the full SHA
    4935434 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2026

  1. [FSSDK-12368] Fix test file formatting issues

    - Update copyright year to 2026
    - Remove unnecessary if __name__ == '__main__' block from test file
    
    Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
    Mat001 and claude committed Apr 13, 2026
    Configuration menu
    Copy the full SHA
    e869ad2 View commit details
    Browse the repository at this point in the history
  2. [FSSDK-12368] Update copyright years to 2026

    Update copyright headers in modified files to include 2026.
    
    Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
    Mat001 and claude committed Apr 13, 2026
    Configuration menu
    Copy the full SHA
    85f661b View commit details
    Browse the repository at this point in the history
  3. [FSSDK-12368] Remove unused imports from test file

    Remove unused imports flagged by ruff:
    - unittest (using unittest.mock instead)
    - decision_service (not used)
    - OptimizelyDecideOption (not used)
    - enums (not used)
    
    Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
    Mat001 and claude committed Apr 13, 2026
    Configuration menu
    Copy the full SHA
    dc57b36 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2026

  1. [FSSDK-12368] Address PR review: simplify types, relocate tests to mo…

    …dule-level files
    
    - Remove NotRequired import and use Optional[list[str]] for HoldoutDict.includedRules
    - Migrate test fixtures from includedFlags/excludedFlags to includedRules
    - Move LocalHoldoutsTest into test_config.py (HoldoutConfigTest + LocalHoldoutConfigTest)
    - Move LocalHoldoutsDecisionFlowTest into test_decision_service_holdout.py
    - Delete test_local_holdouts.py (violated module-level test convention)
    - Tighten weakened assertions to exact counts and content checks
    
    Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
    FarhanAnjum-opti and claude committed Apr 16, 2026
    Configuration menu
    Copy the full SHA
    9c56bc9 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2026

  1. Configuration menu
    Copy the full SHA
    457693c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f921df9 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2026

  1. Refactor feature rollout tests: update rule keys, enhance impression …

    …metadata checks, and add deterministic bucketing logic
    FarhanAnjum-opti committed Apr 21, 2026
    Configuration menu
    Copy the full SHA
    a21f3ef View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2026

  1. Refactor feature rollout tests: enhance test configuration with datac…

    …lass, streamline test execution, and improve setup instructions
    FarhanAnjum-opti committed Apr 22, 2026
    Configuration menu
    Copy the full SHA
    bedceaf View commit details
    Browse the repository at this point in the history
Loading