Consider providing .proto for all API specs · Issue #74 · openzipkin/zipkin-api · GitHub
Skip to content

Consider providing .proto for all API specs  #74

Open

Description

@dio

Currently, zipkin APIs are represented as:

  1. v1, http-json, through https://github.com/openzipkin/zipkin-api/blob/master/zipkin-api.yaml
  2. v2, http-json, through https://github.com/openzipkin/zipkin-api/blob/master/zipkin2-api.yaml and also we have http-proto with messages defined in https://github.com/openzipkin/zipkin-api/blob/master/zipkin.proto

To make it seamless and take advantage of protobuf tooling when making zipkin clients, I think it is a good idea to have .proto for all available API specs (including v1 and v2 http json). E.g. in Envoy we can purely use protobuf helps without a detour on using json lib like rapidjson.

We can consider bringing: https://github.com/nytimes/openapi2proto to generate .proto from openapi spec.

Activity

  1. codefromthecrypt commented on Aug 23, 2019

    @codefromthecrypt
    Member

    didn't notice this issue existed #77 partially implements it. v1 is not reverse mapped yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions