Merge "Add default limit for container/object"

Jenkins · openstack-gerrit · commit f19240fc29c5 · 2016-09-27T02:34:08.000Z
diff --git a/openstackclient/object/v1/container.py b/openstackclient/object/v1/container.py
@@ -15,11 +15,18 @@
 
 """Container v1 action implementations"""
 
+import logging
+
 from osc_lib.cli import parseractions
 from osc_lib.command import command
 from osc_lib import utils
 import six
 
+from openstackclient.i18n import _
+
+
+LOG = logging.getLogger(__name__)
+
 
 class CreateContainer(command.Lister):
     """Create new container"""
@@ -38,6 +45,10 @@ def take_action(self, parsed_args):
 
         results = []
         for container in parsed_args.containers:
+            if len(container) > 256:
+                LOG.warning(
+                    _('Container name is %s characters long, the default limit'
+                      ' is 256'), len(container))
             data = self.app.client_manager.object_store.container_create(
                 container=container,
             )
diff --git a/openstackclient/object/v1/object.py b/openstackclient/object/v1/object.py
@@ -15,12 +15,18 @@
 
 """Object v1 action implementations"""
 
+import logging
 
 from osc_lib.cli import parseractions
 from osc_lib.command import command
 from osc_lib import utils
 import six
 
+from openstackclient.i18n import _
+
+
+LOG = logging.getLogger(__name__)
+
 
 class CreateObject(command.Lister):
     """Upload object to container"""
@@ -44,6 +50,10 @@ def take_action(self, parsed_args):
 
         results = []
         for obj in parsed_args.objects:
+            if len(obj) > 1024:
+                LOG.warning(
+                    _('Object name is %s characters long, default limit'
+                      ' is 1024'), len(obj))
             data = self.app.client_manager.object_store.object_create(
                 container=parsed_args.container,
                 object=obj,
