fix: use correct parsed_args attribute in volume group type show

hong-p · Inyong Hong · commit ca50e0977118 · 2026-05-20T07:37:20.000Z
The ShowVolumeGroupType.take_action() was referencing parsed_args.group instead of parsed_args.group_type, causing an AttributeError on every invocation. Closes-Bug: #2150856 Change-Id: I6924040580af2bc2f30e2bc5f03a366cbb9fe6ef Signed-off-by: hongp <inyong.hong@samsung.com> (cherry picked from commit 05ffb11)
diff --git a/openstackclient/tests/unit/volume/v3/test_volume_group_type.py b/openstackclient/tests/unit/volume/v3/test_volume_group_type.py
@@ -459,3 +459,68 @@ def test_volume_group_type_list_pre_v311(self):
         self.assertIn(
             '--os-volume-api-version 3.11 or greater is required', str(exc)
         )
+
+
+class TestVolumeGroupTypeShow(TestVolumeGroupType):
+    fake_volume_group_type = volume_fakes.create_one_volume_group_type()
+
+    columns = (
+        'ID',
+        'Name',
+        'Description',
+        'Is Public',
+        'Properties',
+    )
+    data = (
+        fake_volume_group_type.id,
+        fake_volume_group_type.name,
+        fake_volume_group_type.description,
+        fake_volume_group_type.is_public,
+        format_columns.DictColumn(fake_volume_group_type.group_specs),
+    )
+
+    def setUp(self):
+        super().setUp()
+
+        self.volume_group_types_mock.get.return_value = (
+            self.fake_volume_group_type
+        )
+
+        self.cmd = volume_group_type.ShowVolumeGroupType(self.app, None)
+
+    def test_volume_group_type_show(self):
+        self.set_volume_api_version('3.11')
+
+        arglist = [
+            self.fake_volume_group_type.id,
+        ]
+        verifylist = [
+            ('group_type', self.fake_volume_group_type.id),
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        columns, data = self.cmd.take_action(parsed_args)
+
+        self.volume_group_types_mock.get.assert_called_once_with(
+            self.fake_volume_group_type.id,
+        )
+        self.assertEqual(self.columns, columns)
+        self.assertCountEqual(self.data, data)
+
+    def test_volume_group_type_show_pre_v311(self):
+        self.set_volume_api_version('3.10')
+
+        arglist = [
+            self.fake_volume_group_type.id,
+        ]
+        verifylist = [
+            ('group_type', self.fake_volume_group_type.id),
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        exc = self.assertRaises(
+            exceptions.CommandError, self.cmd.take_action, parsed_args
+        )
+        self.assertIn(
+            '--os-volume-api-version 3.11 or greater is required', str(exc)
+        )
diff --git a/openstackclient/volume/v3/volume_group_type.py b/openstackclient/volume/v3/volume_group_type.py
@@ -399,7 +399,7 @@ def take_action(self, parsed_args):
 
         group_type = utils.find_resource(
             volume_client.group_types,
-            parsed_args.group,
+            parsed_args.group_type,
         )
 
         return _format_group_type(group_type)
diff --git a/releasenotes/notes/fix-volume-group-type-show-b1c3a2f9e8d047ab.yaml b/releasenotes/notes/fix-volume-group-type-show-b1c3a2f9e8d047ab.yaml
@@ -0,0 +1,7 @@
+---
+fixes:
+  - |
+    Fixed ``volume group type show`` command which was failing with
+    ``AttributeError: 'Namespace' object has no attribute 'group'`` due to
+    a typo in the ``take_action`` method.
+    [Bug `2150856 <https://bugs.launchpad.net/bugs/2150856>`_]

Original file line number	Diff line number	Diff line change
`@@ -399,7 +399,7 @@ def take_action(self, parsed_args):`
`399`	`399`
`400`	`400`	`group_type = utils.find_resource(`
`401`	`401`	`volume_client.group_types,`
`402`		`- parsed_args.group,`
	`402`	`+ parsed_args.group_type,`
`403`	`403`	`)`
`404`	`404`
`405`	`405`	`return _format_group_type(group_type)`