Update the daemonset controller to understand upstream admission config format · Issue #19250 · openshift/origin · GitHub
Skip to content

Update the daemonset controller to understand upstream admission config format #19250

Open

Description

@deads2k

The daemonset controller patch that is optimizing the pods being created by preventing the creation of pods that it knows will fail. The "PodNodeSelector" (the upstream one) admission plugin has a config that doesn't seem to match the "normal" flow. We need to update the controller config parser to find the value.

It'll be in vendor/k8s.io/kubernetes/cmd/kube-controller-manager/app/patch_flags.go after #18989 lands.

@mfojtik @tnozicka @aveshagarwal @sjenning fyi

Activity

  1. added this to the v3.9 milestone on Apr 6, 2018
  2. openshift-bot commented on Jul 6, 2018

    @openshift-bot
    Contributor

    Issues go stale after 90d of inactivity.

    Mark the issue as fresh by commenting /remove-lifecycle stale.
    Stale issues rot after an additional 30d of inactivity and eventually close.
    Exclude this issue from closing by commenting /lifecycle frozen.

    If this issue is safe to close now please do so with /close.

    /lifecycle stale

  3. added
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Jul 6, 2018
  4. tnozicka commented on Jul 9, 2018

    @tnozicka
    Contributor

    /lifecycle frozen

  5. added
    lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.
    and removed
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Jul 9, 2018
  6. rishi-jat commented on Aug 31, 2025

    @rishi-jat

    @deads2k, @tnozicka can I work on this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions