Comparing master...dev-tvos · openid/AppAuth-iOS · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openid/AppAuth-iOS
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: openid/AppAuth-iOS
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dev-tvos
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 59 files changed
  • 2 contributors

Commits on Jul 15, 2020

  1. Import TV authorization flow from GTMAppAuth 

    - Code is from tree https://github.com/google/GTMAppAuth/tree/10d138eb05ad299fd6260741e7b92b0090db0963
- I contributed this code originally to GTMAppAuth on Dec 6, 2016 google/GTMAppAuth@2eb382f
    @WilliamDenniss @soule
    WilliamDenniss authored and soule committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    11e11fd View commit details
    Browse the repository at this point in the history

  2. Modify TV authorization logic for AppAuth 

    - Add beginnings of 'AppAuthTV' Pod subspec
- Remove dependency on `GTMAppAuthFetcherAuthorization`
- Remove GTMAPPAUTH_USER_IMPORTS code
- Verified with `pod lib lint`
    @WilliamDenniss @soule
    WilliamDenniss authored and soule committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    83023d3 View commit details
    Browse the repository at this point in the history

  3. Rename GTM to OID, remove extra headers 

    * Rename OID to GTM, remove extra header
* Remove TVConfigurationForGoogle, update copyright headers
* Return OIDAuthState instead of GTMAppAuthFetcherAuthorization
* Add AppAuthTV to Xcode targets, fix NSObject description method bug
* Add files to AppAuthTV target
* Remove property synthesize
* Add AppAuthTVTests target, pointing to UnitTests/UnitTestsInfo.plist and included in AppAuthTV scheme. Reorder imports
* Update min tvOS version and identifier for AppAuthTV target
* Correct capitalization in AppAuthTV identifier
* Update reference URLs, references to Google removed
* Remove non-functioning AppAuthTVTests target (tests coming in future PR)
* Fix indent spacing in OIDTVServiceConfiguration
    @soule
    soule authored Jul 15, 2020
    Configuration menu
    Copy the full SHA
    9a3a802 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2020

  1. Add AppAuthTV tests 

    * OIDTVAuthorizationRequest tests 
* Add tests to AppAuthTVScheme
* add AppAuthTV to .travis.yml
    @soule
    soule authored Jul 22, 2020
    Configuration menu
    Copy the full SHA
    ecd9f2e View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. Add OIDTVTokenRequest class 

    Adds OIDTVTokenRequest class, which is a subclass of OIDTokenRequest, to better adhere to the [RFC for TV authentication](https://tools.ietf.org/html/rfc8628#section-3.4). This adds the required `device_code` property which is sent in the request body, which differs from the `code` property for the authorization code in the parent class. Additionally, the grant type for TV authorization is hard-coded in, and several unused fields are dropped from the initializer and body request code.
    @soule
    soule authored Jul 29, 2020
    Configuration menu
    Copy the full SHA
    66da408 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. Add OIDTVTokenRequest tests

    @soule
    soule authored Jul 31, 2020
    Configuration menu
    Copy the full SHA
    82bbdd4 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2020

  1. Update for RFC compliance, use new OIDTVTokenRequest class

    @soule
    soule authored Aug 5, 2020
    Configuration menu
    Copy the full SHA
    a8ab285 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2020

  1. Add OIDTVAuthorizationResponse tests

    @soule
    soule authored Aug 7, 2020
    Configuration menu
    Copy the full SHA
    9ec12f6 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. Add updated tvOS example project

    @soule
    soule authored Aug 11, 2020
    Configuration menu
    Copy the full SHA
    785076d View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. Add OIDC Discovery for the Device Authorization Endpoint 

    Update the example project to support discovery
    @soule
    soule authored Aug 13, 2020
    Configuration menu
    Copy the full SHA
    1cfdff1 View commit details
    Browse the repository at this point in the history
Loading