{{ message }}
Repository navigation
fix(typing): explicitly specialize ToolContext[Any] in ToolFunctionWithToolContext #5387
Description
Description & Motivation
In src/agents/tool.py, ToolFunctionWithToolContext is defined with an unspecialized ToolContext:
ToolFunctionWithoutContext = Callable[ToolParams, Any]
ToolFunctionWithContext = Callable[Concatenate[RunContextWrapper[Any], ToolParams], Any]
ToolFunctionWithToolContext = Callable[Concatenate[ToolContext, ToolParams], Any]
Activity
AbarnaaSree commentedon Oct 18, 2026
Hi, I’d like to work on this issue. Would it be okay if I update
ToolFunctionWithToolContextto explicitly useToolContext[Any], check for any related typing inconsistencies, and add or update tests to ensure the change preserves existing type-checking behavior? I’ll keep the change focused and run the relevant tests and type checks before submitting a PR.MuneebMalik244535 commentedon Oct 18, 2026
Hi @AbarnaaSree, thanks for reaching out!
Just to clarify, the complete fix and regression test have already been implemented, fully tested, and linked in the issue description above:
fix/specialize-tool-context-any3322faa6Also note that per this repository's
CONTRIBUTING.md, pull requests are currently limited to repository collaborators. We are currently waiting for a maintainer to review the RCA and either cherry-pick the linked commit or open a collaborator PR.Thanks!
AbarnaaSree commentedon Oct 18, 2026
Thanks for clarifying! I understand that the fix and regression test are already implemented and awaiting maintainer review. I’ll avoid duplicating the work and would be happy to help review the proposed changes or validate any additional edge cases if needed.