docs(ofrep): keep the evidence, link the rules, delete the retellings · open-feature/python-sdk-contrib@da6aeb8 · GitHub
Skip to content

Commit da6aeb8

Browse files
committed
docs(ofrep): keep the evidence, link the rules, delete the retellings
test_ofrep.py was 368 lines to 35 of code, and the surplus was around the reasoning rather than in it: Appendix F's declaring rules quoted at length, the same spec revisions cited tag by tag, and two paragraphs comparing what the Java and Go OFREP adoptions did -- which is in PR #414's body, where a reviewer comparing four languages is actually looking. Both withholdings keep their measurements whole, because they are the two things here nothing else records: - @numeric-coercion, withheld because this provider never coerces -- json.loads keeps int and float apart and the check admits a value only on an exact isinstance, so the lossy row passes and a lossless one fails. Over OFREP the capability follows the language's JSON library. - @disabled-flags, withheld for a defect rather than an architecture, and the whole gap is one unconditional `data["variant"]` index on a member the protocol types optional. The wire response is kept, the measurement is kept, and the acknowledgement that this is the one declaration the corrected appendix says should change shape is kept in short form, pointing at PR #414 where the decision and the same measurement are recorded in full. The note also stops calling the defect unfiled: it is #418. Two claims went because they had gone stale rather than because they were duplication. The file argued at length with the appendix's rationale for gating @disabled-flags -- "a provider whose backend decides, such as one speaking OFREP, cannot" -- and the appendix no longer says it, so the rebuttal had nothing to rebut. settled_control.py keeps what it is and why it lives in this adoption rather than in the shared harness, and hands the mechanism of the window to open-feature/flagd-testbed#394, which explains it down to the buffered channel in flagd's file sync and measures it. Comments and docstrings only. The suite still reports 2 failed, 45 passed, 17 skipped, 1 xfailed. Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
1 parent d7d71f0 commit da6aeb8

3 files changed

Lines changed: 173 additions & 332 deletions

File tree

‎providers/openfeature-provider-ofrep/tests/tck/conftest.py‎

Lines changed: 28 additions & 33 deletions

‎providers/openfeature-provider-ofrep/tests/tck/settled_control.py‎

Lines changed: 24 additions & 47 deletions

0 commit comments

Comments
 (0)