{{ message }}
Repository navigation
Commit 64845cd
committed
test(flagd): follow the @numeric-coercion rename
The capability was renamed on the base branch, so these declarations named a
symbol that no longer exists. Both resolvers keep declaring it: this provider
satisfies the rule in both paths, which is worth noting because the other two
languages' flagd providers do not.
The rationale comments already recorded why, and they are now the evidence that
the defect is narrower than it was described as being. RPC asks flagd for an Int
and flagd answers INVALID_ARGUMENT for a float-valued flag, which the provider
maps to TypeMismatchError. In-process is local and strict: an integer request
admits only int, and the float mapping is deliberately the wider (int, float)
because widening towards float loses nothing -- which is the lossless-coercion
rule arrived at independently, before it had a name here.
So flagd's float narrowing is a property of the Go and Java provider layers
rather than of flagd itself. The Go adoption's comment currently says the
opposite, calling it "a flagd-wide issue", and needs correcting.
Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>1 parent b1a77e8 commit 64845cd
2 files changed
Lines changed: 4 additions & 4 deletions
File tree
- providers/openfeature-provider-flagd/tests/tck
0 commit comments