test(tck): stop naming one testbed release as the flag set's boundary · open-feature/python-sdk-contrib@00535a5 · GitHub
Skip to content

Commit 00535a5

Browse files
committed
test(tck): stop naming one testbed release as the flag set's boundary
Several comments said flagd-testbed "v3.8.0" seeds neither large-integer-flag nor integral-float-flag. The Compose file moved to v3.10.1 and those flags are absent from that release too, so naming one version invited the reader to conclude the other serves them and that the failures were a pin away from going green. They are not: open-feature/flagd-testbed#392 is what adds the flags, and it is open. Now phrased as no released testbed seeding them, which stays true until #392 lands and false the moment it does -- which is when these comments should be revisited anyway. Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
1 parent ca65e19 commit 00535a5

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎providers/openfeature-provider-flagd/tests/tck/conftest.py‎

Lines changed: 1 addition & 1 deletion

‎providers/openfeature-provider-flagd/tests/tck/test_in_process.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@
126126
#
127127
# LARGE_INTEGERS
128128
# Withheld. Exactly one scenario carries the tag, it asks for
129-
# `huge-integer-flag`, and flagd-testbed v3.8.0 seeds no such flag -- so this
129+
# `huge-integer-flag`, and no released flagd-testbed seeds such a flag -- so this
130130
# backend can put none of the tag's scenarios to this provider, and Appendix
131131
# F's sixth declaring rule says withhold. Python's `int` is unbounded and the
132132
# ruleset arrives as JSON text parsed with `json.loads` (flagd_core.py:73),

‎providers/openfeature-provider-flagd/tests/tck/test_rpc.py‎

Lines changed: 1 addition & 1 deletion

0 commit comments

Comments
 (0)