Refactor KeyStoreSettings : Change KeyStore password to KeyEntry Password by Chandra158 · Pull Request #243 · SAML-Toolkits/java-saml · GitHub
Skip to content

Refactor KeyStoreSettings : Change KeyStore password to KeyEntry Password#243

Merged
pitbulk merged 2 commits into
SAML-Toolkits:masterfrom
Chandra158:ticket-fix-keyStore
Oct 14, 2019
Merged

Refactor KeyStoreSettings : Change KeyStore password to KeyEntry Password#243
pitbulk merged 2 commits into
SAML-Toolkits:masterfrom
Chandra158:ticket-fix-keyStore

Conversation

@Chandra158

Copy link
Copy Markdown
Contributor

Description

The password for KeyEntry in KeyStore can be different than that of KeyStore password itself.

  • storePass : Password to access KeyStore
  • spKeyPass : Password to access KeyEntry in the KeyStore

The KeyStoreSettings should mention spKeyPass instead of storePass.
(StorePass is not required as KeyStore is already loaded and passed while constructing KeyStoreSettings)

Changes in the PR

  • Replaced the KeyStore file which has different password for KeyStore and KeyEntry in the KeyStore.
    • KeyStore : (oneloginTestKeystore.jks; password : changeit)
    • KeyEntry : (alias: keywithpassword; password : keypassword)
  • Changed storePass to spKeyPass in KeyStoreSettings.
  • Refactored unit tests as per above change.
  • Updated README.md.

How Has This Been Tested?

Tested with unit tests.

Types of changes

  • Refactor code
  • Fixes description

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • All new and existing tests passed.

@coveralls

coveralls commented Oct 11, 2019

Copy link
Copy Markdown

@pitbulk pitbulk merged commit 58fc792 into SAML-Toolkits:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants