{{ message }}
Refactor KeyStoreSettings : Change KeyStore password to KeyEntry Password#243
Merged
Merged
Conversation
4f285a5 to
32025f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
The password for
KeyEntryin KeyStore can be different than that of KeyStore password itself.The KeyStoreSettings should mention
spKeyPassinstead ofstorePass.(StorePass is not required as KeyStore is already loaded and passed while constructing KeyStoreSettings)
Changes in the PR
oneloginTestKeystore.jks; password :changeit)keywithpassword; password :keypassword)storePasstospKeyPassin KeyStoreSettings.unit testsas per above change.README.md.How Has This Been Tested?
Tested with
unittests.Types of changes
Checklist: