FilesExpand file tree

main

/

.golangci.yml

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

214 lines (212 loc) · 7.83 KB

main

/

.golangci.yml

Copy path

Top

File metadata and controls

• Code
• Blame

214 lines (212 loc) · 7.83 KB

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

29

30

31

32

33

34

35

36

37

38

39

40

41

42

43

44

45

46

47

48

49

50

51

52

53

54

55

56

57

58

59

60

61

62

63

64

65

66

67

68

69

70

71

72

73

74

75

76

77

78

79

80

81

82

83

84

85

86

87

88

89

90

91

92

93

94

95

96

97

98

99

100

101

102

103

104

105

106

107

108

109

110

111

112

113

114

115

116

117

118

119

120

121

122

123

124

125

126

127

128

129

130

131

132

133

134

135

136

137

138

139

140

141

142

143

144

145

146

147

148

149

150

151

152

153

154

155

156

157

158

159

160

161

162

163

164

165

166

167

168

169

170

171

172

173

174

175

176

177

178

179

180

181

182

183

184

185

186

187

188

189

190

191

192

193

194

195

196

197

198

199

200

201

202

203

204

205

206

207

208

209

210

211

212

213

214

version: "2"

run:

timeout: 5m

linters:

default: none

enable:

# Existing baseline.

- errcheck

- govet

- omnaralint

- staticcheck

# Bug finders. Each catches a class of correctness mistake that the

# baseline four do not and aligns with the repository's correctness bar.

- asasalint # []any accidentally passed to func(...any)

- bidichk # dangerous bidi unicode in source

- bodyclose # http.Response.Body left unclosed

- canonicalheader # net/http header keys use canonical casing

- containedctx # context.Context stored in structs leaks lifetimes

- contextcheck # non-inherited context.Context used downstream

- copyloopvar # redundant loop-variable copies (Go 1.22+)

- depguard # deny dependencies that conflict with repo policy

- durationcheck # time.Duration * time.Duration mistakes

- errorlint # wrong error wrapping / type-assertion patterns

- errname # error types follow Go naming conventions

- errchkjson # unsafe JSON marshal/encode errors ignored

- exhaustive # non-exhaustive enum switches

- fatcontext # context nested in a loop / closure

- forcetypeassert # type assertions must check the ok result

- gocheckcompilerdirectives # malformed //go: directives

- gomoddirectives # invalid go.mod directive usage

- ineffassign # assignments overwritten before being read

- intrange # for i := 0; i < n; i++ -> for i := range n

- lll # keep product Go source readable in review

- loggercheck # malformed slog key/value pairs

- makezero # make([]T, n) then append, etc.

- nilerr # `return nil` after `if err != nil`

- nilnesserr # related nil-error misuse (govet nilness companion)

- noctx # http.NewRequest / exec.Command without context

- nilnil # simultaneous nil error and invalid nil value

- nolintlint # nolint directives must be explicit and reviewable

- predeclared # shadows builtins (len, new, error, ...)

- promlinter # Prometheus metric names follow best practices

- reassign # package-level vars reassigned at runtime

- recvcheck # mixed pointer/value receivers on a type

- rowserrcheck # pgx/database/sql Rows.Err() not checked

- spancheck # OpenTelemetry spans not ended / status not set

- sqlclosecheck # Rows/Stmt not closed

- tparallel # misuse of t.Parallel

- testifylint

- unconvert # redundant type conversion

- unused # unreferenced private code and declarations

- usestdlibvars # http.MethodGet, http.StatusOK, ... over literals

- usetesting # use the testing package's modern helpers

- wastedassign # value assigned but never read

# Style/correctness hybrid. Misspellings show up in user-facing strings,

# API docs, and migration comments, so this catches more than aesthetics.

- misspell

settings:

testifylint:

disable-all: true

enable:

- go-require

go-require:

ignore-http-handlers: false

staticcheck:

checks:

- all

- -QF*

- -ST1000

errorlint:

errorf: true

asserts: true

comparison: true

exhaustive:

default-signifies-exhaustive: true

misspell:

locale: US

lll:

line-length: 120

tab-width: 1

rowserrcheck:

packages:

- github.com/jackc/pgx/v5

custom:

omnaralint:

type: module

description: Omnara repository-specific invariants.

depguard:

rules:

main:

list-mode: lax

deny:

- pkg: "math/rand$"

desc: use crypto/rand for tokens and IDs; math/rand/v2 is a separate import and must be justified in review

- pkg: github.com/pkg/errors

desc: use standard-library errors plus fmt.Errorf with %w

production_test_support:

list-mode: lax

files:

- $all

- "!$test"

- "!**/internal/testutil/**"

deny:

- pkg: github.com/omnara-ai/omnara/internal/testutil

desc: test support belongs in _test.go or internal/testutil, never in production dependencies

generated_storage_boundary:

list-mode: lax

files:

- $all

- "!**/internal/storage/**"

deny:

- pkg: github.com/omnara-ai/omnara/internal/storage/dbsqlc

desc: generated sqlc types must stay behind semantic internal/storage methods

daemon_state_storage_boundary:

list-mode: lax

files:

- "**/cmd/daemon/**"

- "**/internal/machinedaemon/**"

- "**/internal/omnarad/**"

- "!**/internal/machinedaemon/statedb/**"

deny:

- pkg: database/sql

desc: daemon SQL access belongs in internal/machinedaemon/statedb

- pkg: modernc.org/sqlite

desc: daemon SQLite access belongs in internal/machinedaemon/statedb

errcheck:

check-type-assertions: false

gomoddirectives:

# The root module builds against the in-repo observability module.

replace-local: true

replace-allow-list:

- github.com/omnara-ai/omnara/observability

exclude-forbidden: true

ignore-forbidden: true

toolchain-forbidden: true

nolintlint:

require-specific: true

require-explanation: true

exclusions:

generated: disable

rules:

- path: internal/storage/internal/agentexecution/internal/executiondb/batch\.go

linters:

- intrange

- path: internal/storage/internal/(storeutil/pool|agentexecution/database)\.go

source: '(\.Query\(ctx, (sql|query), args\.\.\.\)|b\.BatchResults\.Query\(\))'

linters:

- rowserrcheck

# oapi-codegen's oneOf wrappers intentionally mix value accessors with

# pointer mutation methods; the generated file is not hand-editable.

- path: internal/httpapi/openapi/api\.gen\.go

linters:

- recvcheck

- linters:

- lll

source: '^const [A-Za-z0-9_]+ = "'

- linters:

- lll

source: '^\s*[A-Za-z0-9_]+ := `'

- linters:

- lll

source: '^\s*`'

- linters:

- lll

source: '^\s*"'

- linters:

- lll

source: 'json\.RawMessage\(`'

- linters:

- lll

source: '^\s*return "'

- linters:

- lll

source: '^\s*want: "'

- linters:

- lll

source: '^\s*\{"slug"'

- linters:

- lll

source: '^\s*[A-Za-z0-9_]+ToolDescription\s*='

- linters:

- lll

source: '^\s*\)\.[A-Za-z]'

- path: (internal/storage/internal/dbsqlc/|internal/storage/internal/agentexecution/internal/executiondb/|internal/machinedaemon/statedb/internal/dbsqlc/)

linters:

- errcheck

- govet

- lll

- staticcheck

- path: internal/httpapi/openapi/api\.gen\.go

linters:

- errcheck

- forcetypeassert

- lll

- misspell

- usestdlibvars

# protoc-gen-go output for the boxd provider's gRPC bindings.

- path: internal/machinepool/providers/boxd/boxdv1/

linters:

- errcheck

- forcetypeassert

- lll

- misspell

- recvcheck

- staticcheck

- unused

- path: _test\.go

linters:

- errcheck

- bodyclose

- contextcheck

- noctx