fix: package.json vs lockfile mismatch for readiness-core · octo-patch/loop-engineering@c77ac2b · GitHub
Skip to content

Commit c77ac2b

Browse files
THRISHAL12345THRISHAL12345
committed
fix: package.json vs lockfile mismatch for readiness-core
1 parent 0792e03 commit c77ac2b

6 files changed

Lines changed: 27 additions & 61 deletions

File tree

‎.github/workflows/release-goal-audit.yml‎

Lines changed: 11 additions & 13 deletions

‎.github/workflows/release-loop-audit.yml‎

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -38,24 +38,22 @@ jobs:
3838
- name: Install, build, test
3939
working-directory: tools/loop-audit
4040
run: |
41-
# Build monorepo sibling first — declared ^range may not be on npm yet
41+
# Build monorepo sibling first
4242
(cd ../readiness-core && npm ci && npm run build)
43-
cp package.json package.json.release-bak
44-
cp package-lock.json package-lock.json.release-bak
45-
node -e "
46-
const fs = require('fs');
47-
const p = JSON.parse(fs.readFileSync('package.json', 'utf8'));
48-
p.dependencies['@cobusgreyling/readiness-core'] = 'file:../readiness-core';
49-
fs.writeFileSync('package.json', JSON.stringify(p, null, 2) + '\n');
50-
"
51-
npm install
52-
mv package.json.release-bak package.json
53-
mv package-lock.json.release-bak package-lock.json
43+
npm ci
5444
npm run build
5545
npm test
5646
5747
- name: Publish to npm
5848
working-directory: tools/loop-audit
59-
run: npm publish --access public --provenance
49+
run: |
50+
# Rewrite to registry version for publish
51+
node -e "
52+
const fs = require('fs');
53+
const p = JSON.parse(fs.readFileSync('package.json', 'utf8'));
54+
p.dependencies['@cobusgreyling/readiness-core'] = '^1.0.0';
55+
fs.writeFileSync('package.json', JSON.stringify(p, null, 2) + '\n');
56+
"
57+
npm publish --access public --provenance
6058
env:
6159
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

‎scripts/ci-audit-gates.sh‎

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,7 @@ echo "Building readiness-core…"
1212
)
1313

1414
cd "$REPO_ROOT/tools/loop-audit"
15-
cp package.json package.json.ci-bak
16-
cp package-lock.json package-lock.json.ci-bak
17-
node -e "
18-
const fs = require('fs');
19-
const p = JSON.parse(fs.readFileSync('package.json', 'utf8'));
20-
p.dependencies['@cobusgreyling/readiness-core'] = 'file:../readiness-core';
21-
fs.writeFileSync('package.json', JSON.stringify(p, null, 2) + '\n');
22-
"
23-
npm install
24-
mv package.json.ci-bak package.json
25-
mv package-lock.json.ci-bak package-lock.json
15+
npm ci
2616
npm test
2717
echo "=== Audit of repo root ==="
2818
node dist/cli.js "$REPO_ROOT" --json > /tmp/root-audit.json

‎scripts/ci-validate-gates.sh‎

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -40,34 +40,14 @@ echo "Building and testing readiness-core…"
4040
echo "Building and testing loop-audit…"
4141
(
4242
cd tools/loop-audit
43-
cp package.json package.json.ci-bak
44-
cp package-lock.json package-lock.json.ci-bak
45-
node -e "
46-
const fs = require('fs');
47-
const p = JSON.parse(fs.readFileSync('package.json', 'utf8'));
48-
p.dependencies['@cobusgreyling/readiness-core'] = 'file:../readiness-core';
49-
fs.writeFileSync('package.json', JSON.stringify(p, null, 2) + '\n');
50-
"
51-
npm install
52-
mv package.json.ci-bak package.json
53-
mv package-lock.json.ci-bak package-lock.json
43+
npm ci
5444
npm test
5545
)
5646

5747
echo "Building and testing goal-audit…"
5848
(
5949
cd tools/goal-audit
60-
cp package.json package.json.ci-bak
61-
cp package-lock.json package-lock.json.ci-bak
62-
node -e "
63-
const fs = require('fs');
64-
const p = JSON.parse(fs.readFileSync('package.json', 'utf8'));
65-
p.dependencies['@cobusgreyling/readiness-core'] = 'file:../readiness-core';
66-
fs.writeFileSync('package.json', JSON.stringify(p, null, 2) + '\n');
67-
"
68-
npm install
69-
mv package.json.ci-bak package.json
70-
mv package-lock.json.ci-bak package-lock.json
50+
npm ci
7151
npm test
7252
)
7353

‎tools/goal-audit/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,6 @@
4747
"typescript": "^5.0.0"
4848
},
4949
"dependencies": {
50-
"@cobusgreyling/readiness-core": "^1.0.0"
50+
"@cobusgreyling/readiness-core": "file:../readiness-core"
5151
}
5252
}

‎tools/loop-audit/package.json‎

Lines changed: 1 addition & 1 deletion

0 commit comments

Comments
 (0)