FilesExpand file tree

 main

/

EmptyArrayInit.ql

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

51 lines (46 loc) · 1.61 KB

 main

/

EmptyArrayInit.ql

Copy path

Top

File metadata and controls

• Code
• Blame

51 lines (46 loc) · 1.61 KB

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

29

30

31

32

33

34

35

36

37

38

39

40

41

42

43

44

45

46

47

48

49

50

51

/**

* @name Omitted array element

* @description Omitted elements in array literals are easy to miss and should not be used.

* @kind problem

* @problem.severity recommendation

* @id js/omitted-array-element

* @tags maintainability

* readability

* language-features

* @precision low

*/

import javascript

/**

* An initial omitted element in an array expression.

*

* This is represented by the corresponding array expression, with a special

* `hasLocationInfo` implementation that assigns it a location covering the

* first omitted array element.

*/

class OmittedArrayElement extends ArrayExpr {

int idx;

OmittedArrayElement() { idx = min(int i | this.elementIsOmitted(i)) }

/**

* Holds if this element is at the specified location.

* The location spans column `startcolumn` of line `startline` to

* column `endcolumn` of line `endline` in file `filepath`.

* For more information, see

* [Locations](https://codeql.github.com/docs/writing-codeql-queries/providing-locations-in-codeql-queries/).

*/

predicate hasLocationInfo(

string filepath, int startline, int startcolumn, int endline, int endcolumn

) {

exists(Token pre, Location before, Location after |

idx = 0 and pre = this.getFirstToken()

or

pre = this.getElement(idx - 1).getLastToken().getNextToken()

|

before = pre.getLocation() and

after = pre.getNextToken().getLocation() and

before.hasLocationInfo(filepath, startline, startcolumn, _, _) and

after.hasLocationInfo(_, _, _, endline, endcolumn)

)

}

}

from OmittedArrayElement ae

select ae, "Avoid omitted array elements."