gyp: rm semicolons (Python != JavaScript) · nodejs/node-gyp@a976151 · GitHub
Skip to content

Commit a976151

Browse files
MattIPv4rvagg
authored andcommitted
gyp: rm semicolons (Python != JavaScript)
PR-URL: #1858 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Rod Vagg <r@va.gg>
1 parent 06019ba commit a976151

5 files changed

Lines changed: 17 additions & 17 deletions

File tree

gyp/pylib/gyp/common_test.py

Lines changed: 4 additions & 4 deletions

gyp/pylib/gyp/generator/analyzer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -615,7 +615,7 @@ def _supplied_target_names(self):
615615

616616
def _supplied_target_names_no_all(self):
617617
"""Returns the supplied test targets without 'all'."""
618-
result = self._supplied_target_names();
618+
result = self._supplied_target_names()
619619
result.discard('all')
620620
return result
621621

@@ -668,7 +668,7 @@ def find_matching_test_target_names(self):
668668

669669
def find_matching_compile_target_names(self):
670670
"""Returns the set of output compile targets."""
671-
assert self.is_build_impacted();
671+
assert self.is_build_impacted()
672672
# Compile targets are found by searching up from changed targets.
673673
# Reset the visited status for _GetBuildTargets.
674674
for target in self._name_to_target.values():

gyp/pylib/gyp/generator/cmake.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -681,7 +681,7 @@ def WriteTarget(namer, qualified_target, target_dicts, build_dir, config_to_use,
681681
for src in srcs:
682682
_, ext = os.path.splitext(src)
683683
src_type = COMPILABLE_EXTENSIONS.get(ext, None)
684-
src_norm_path = NormjoinPath(path_from_cmakelists_to_gyp, src);
684+
src_norm_path = NormjoinPath(path_from_cmakelists_to_gyp, src)
685685

686686
if src_type == 's':
687687
s_sources.append(src_norm_path)

gyp/pylib/gyp/generator/make.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1225,16 +1225,16 @@ def WriteSources(self, configs, deps, sources,
12251225
cflags_c = config.get('cflags_c')
12261226
cflags_cc = config.get('cflags_cc')
12271227

1228-
self.WriteLn("# Flags passed to all source files.");
1228+
self.WriteLn("# Flags passed to all source files.")
12291229
self.WriteList(cflags, 'CFLAGS_%s' % configname)
1230-
self.WriteLn("# Flags passed to only C files.");
1230+
self.WriteLn("# Flags passed to only C files.")
12311231
self.WriteList(cflags_c, 'CFLAGS_C_%s' % configname)
1232-
self.WriteLn("# Flags passed to only C++ files.");
1232+
self.WriteLn("# Flags passed to only C++ files.")
12331233
self.WriteList(cflags_cc, 'CFLAGS_CC_%s' % configname)
12341234
if self.flavor == 'mac':
1235-
self.WriteLn("# Flags passed to only ObjC files.");
1235+
self.WriteLn("# Flags passed to only ObjC files.")
12361236
self.WriteList(cflags_objc, 'CFLAGS_OBJC_%s' % configname)
1237-
self.WriteLn("# Flags passed to only ObjC++ files.");
1237+
self.WriteLn("# Flags passed to only ObjC++ files.")
12381238
self.WriteList(cflags_objcc, 'CFLAGS_OBJCC_%s' % configname)
12391239
includes = config.get('include_dirs')
12401240
if includes:
@@ -1779,7 +1779,7 @@ def WriteMakeRule(self, outputs, inputs, actions=None, comment=None,
17791779
cmddigest = hashlib.sha1(command if command else self.target).hexdigest()
17801780
intermediate = "%s.intermediate" % cmddigest
17811781
self.WriteLn('%s: %s' % (' '.join(outputs), intermediate))
1782-
self.WriteLn('\t%s' % '@:');
1782+
self.WriteLn('\t%s' % '@:')
17831783
self.WriteLn('%s: %s' % ('.INTERMEDIATE', intermediate))
17841784
self.WriteLn('%s: %s%s' %
17851785
(intermediate, ' '.join(inputs), force_append))

gyp/pylib/gyp/generator/xcode.py

Lines changed: 4 additions & 4 deletions

0 commit comments

Comments
 (0)