lib: ignore VS instances that cause COMExceptions

amcasey · joaocgreis · commit 1f7e1e93b511 · 2020-01-14T15:59:29.000Z
I have quite a few instances of VS installed and it looks like Find-VisualStudio.cs enumerates all of them, even when find-visualstudio.js already knows which one it wants (from the environment variable in the developer command prompt). One of them (from 15.7.2, if that's interesting) causes a COMException on the ISetupInstance2.GetPackages call. Ignoring such packages seems harmless and unblocks the rest of the run. PR-URL: #2018 Reviewed-By: João Reis <reis@janeasystems.com>
diff --git a/lib/Find-VisualStudio.cs b/lib/Find-VisualStudio.cs
@@ -205,7 +205,14 @@ public static void PrintJson()
                     return;
                 }
 
-                instances.Add(InstanceJson(rgelt[0]));
+                try
+                {
+                    instances.Add(InstanceJson(rgelt[0]));
+                }
+                catch (COMException)
+                {
+                    // Ignore instances that can't be queried.
+                }
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,14 @@ public static void PrintJson()`
`205`	`205`	`return;`
`206`	`206`	`}`
`207`	`207`
`208`		`- instances.Add(InstanceJson(rgelt[0]));`
	`208`	`+ try`
	`209`	`+ {`
	`210`	`+ instances.Add(InstanceJson(rgelt[0]));`
	`211`	`+ }`
	`212`	`+ catch (COMException)`
	`213`	`+ {`
	`214`	`+ // Ignore instances that can't be queried.`
	`215`	`+ }`
`209`	`216`	`}`
`210`	`217`	`}`
`211`	`218`