lib: ignore non-critical os.userInfo() failures

rvagg · rvagg · commit 1186e8932644 · 2019-09-26T13:39:38.000+10:00
Fixes: #1834 PR-URL: #1835
diff --git a/lib/install.js b/lib/install.js
@@ -370,7 +370,12 @@ function install (fs, gyp, argv, callback) {
     }
     var tmpdir = os.tmpdir()
     gyp.devDir = path.resolve(tmpdir, '.node-gyp')
-    log.warn('EACCES', 'user "%s" does not have permission to access the dev dir "%s"', os.userInfo().username, devDir)
+    var userString = ''
+    try {
+      // os.userInfo can fail on some systems, it's not critical here
+      userString = ` ("${os.userInfo().username}")`
+    } catch (e) {}
+    log.warn('EACCES', 'current user%s does not have permission to access the dev dir "%s"', userString, devDir)
     log.warn('EACCES', 'attempting to reinstall using temporary dev dir "%s"', gyp.devDir)
     if (process.cwd() === tmpdir) {
       log.verbose('tmpdir == cwd', 'automatically will remove dev files after to save disk space')
