{{ message }}
fix: add missing const to ObjectReference::Set string parameter#1713
Merged
legendecas merged 1 commit intonodejs:mainfrom Mar 6, 2026
Merged
fix: add missing const to ObjectReference::Set string parameter#1713legendecas merged 1 commit intonodejs:mainfrom
legendecas merged 1 commit intonodejs:mainfrom
Conversation
legendecas
approved these changes
Mar 4, 2026
github-project-automation
Bot
moved this from Need Triage
to Done
in Node-API Team Project
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ObjectReference::Set(const std::string&, std::string&)overload was missing aconstqualifier on the value parameter, making it inconsistent with other Set overloads. This prevented passing temporarystd::stringobjects (rvalues).Adding
constallows for more flexible usage without unnecessary string copies.