test: remove --always-turbofan flag

targos · targos · commit faba50df9615 · 2025-10-04T18:48:39.000+02:00
It was removed from V8. Refs: v8/v8@7779ff0 PR-URL: #59805 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/test/fixtures/linux-perf-logger.js b/test/fixtures/linux-perf-logger.js
@@ -2,6 +2,8 @@
 
 process.stdout.write(`${process.pid}`);
 
+const wantOptimization = !process.argv.includes('--no-opt');
+
 const testRegex = /test-regex/gi;
 
 function functionOne() {
@@ -14,4 +16,16 @@ function functionTwo() {
   functionOne();
 }
 
+if (wantOptimization) {
+  %PrepareFunctionForOptimization(functionOne);
+  %PrepareFunctionForOptimization(functionTwo);
+}
+
+functionTwo();
+
+if (wantOptimization) {
+  %OptimizeFunctionOnNextCall(functionOne);
+  %OptimizeFunctionOnNextCall(functionTwo);
+}
+
 functionTwo();
diff --git a/test/v8-updates/test-linux-perf-logger.js b/test/v8-updates/test-linux-perf-logger.js
@@ -42,7 +42,7 @@ tmpdir.refresh();
 const testCases = [
   {
     title: '--perf-basic-prof interpreted',
-    nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--no-opt'],
+    nodeFlags: ['--allow-natives-syntax', '--perf-basic-prof', '--no-turbo-inlining', '--no-opt'],
     matches: [
       'JS:~functionOne .+/linux-perf-logger.js',
       'JS:~functionTwo .+/linux-perf-logger.js',
@@ -55,8 +55,7 @@ const testCases = [
   },
   {
     title: '--perf-basic-prof compiled',
-    nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--always-turbofan',
-                '--minimum-invocations-before-optimization=0'],
+    nodeFlags: ['--allow-natives-syntax', '--perf-basic-prof', '--no-turbo-inlining'],
     matches: [
       String.raw`RegExp\.> src: 'test-regex' flags: 'gi'`,
       'JS:~functionOne .+/linux-perf-logger.js',
@@ -68,7 +67,7 @@ const testCases = [
   },
   {
     title: '--perf-basic-prof-only-functions interpreted',
-    nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--no-opt'],
+    nodeFlags: ['--allow-natives-syntax', '--perf-basic-prof-only-functions', '--no-turbo-inlining', '--no-opt'],
     matches: [
       'JS:~functionOne .+/linux-perf-logger.js',
       'JS:~functionTwo .+/linux-perf-logger.js',
@@ -81,8 +80,7 @@ const testCases = [
   },
   {
     title: '--perf-basic-prof-only-functions compiled',
-    nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--always-turbofan',
-                '--minimum-invocations-before-optimization=0'],
+    nodeFlags: ['--allow-natives-syntax', '--perf-basic-prof-only-functions', '--no-turbo-inlining'],
     matches: [
       'JS:~functionOne .+/linux-perf-logger.js',
       'JS:~functionTwo .+/linux-perf-logger.js',
diff --git a/test/v8-updates/test-linux-perf.js b/test/v8-updates/test-linux-perf.js
@@ -61,7 +61,6 @@ const perfCompiledFramesArgs = [
   '--',
   process.execPath,
   ...nodeCommonFlags,
-  '--always-turbofan',
   fixtures.path('linux-perf.js'),
   `${sleepTime}`,
   `${repeat}`,
diff --git a/tools/test.py b/tools/test.py
@@ -1677,9 +1677,6 @@ def Main():
   if options.check_deopts:
     options.node_args.append("--trace-opt")
     options.node_args.append("--trace-file-names")
-    # --always-turbofan is needed because many tests do not run long enough for
-    # the optimizer to kick in, so this flag will force it to run.
-    options.node_args.append("--always-turbofan")
     options.progress = "deopts"
 
   if options.error_reporter:
