test: check bundled binaries are signed on macOS

richardlau · targos · commit fa4de53a3e5c · 2020-04-22T18:34:44.000+02:00
For notarization on macOS all packaged binaries must be signed. Add a regression test to check that known binaries from our dependencies (at the time of this commit term-size via npm) are signed. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32522 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/test/parallel/test-macos-signed-deps.js b/test/parallel/test-macos-signed-deps.js
@@ -0,0 +1,31 @@
+'use strict';
+
+// Notarization on macOS requires all binaries to be signed.
+// We sign our own binaries but check here if any binaries from our dependencies
+// (e.g. npm) are signed.
+const common = require('../common');
+
+if (!common.isOSX) {
+  common.skip('macOS specific test');
+}
+
+const assert = require('assert');
+const { spawnSync } = require('child_process');
+const path = require('path');
+
+const debuglog = require('util').debuglog('test');
+
+const binaries = [
+  'deps/npm/node_modules/term-size/vendor/macos/term-size',
+];
+
+for (const testbin of binaries) {
+  const bin = path.resolve(__dirname, '..', '..', testbin);
+  debuglog(`Checking ${bin}`);
+  const cp = spawnSync('codesign', [ '-vvvv', bin ], { encoding: 'utf8' });
+  debuglog(cp.stdout);
+  debuglog(cp.stderr);
+  assert.strictEqual(cp.signal, null);
+  assert.strictEqual(cp.status, 0, `${bin} does not appear to be signed.\n` +
+                     `${cp.stdout}\n${cp.stderr}`);
+}
