src: remove validation of unreachable code

juanarbol · BethGriggs · commit f9b8988df6cd · 2020-04-27T20:40:42.000+01:00
Based on nodejs/help#2600 (comment) the condition (amount < 0) won't be possible. PR-URL: #32818 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
diff --git a/src/node_os.cc b/src/node_os.cc
@@ -132,16 +132,12 @@ static void GetCPUInfo(const FunctionCallbackInfo<Value>& args) {
 
 static void GetFreeMemory(const FunctionCallbackInfo<Value>& args) {
   double amount = uv_get_free_memory();
-  if (amount < 0)
-    return;
   args.GetReturnValue().Set(amount);
 }
 
 
 static void GetTotalMemory(const FunctionCallbackInfo<Value>& args) {
   double amount = uv_get_total_memory();
-  if (amount < 0)
-    return;
   args.GetReturnValue().Set(amount);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -132,16 +132,12 @@ static void GetCPUInfo(const FunctionCallbackInfo<Value>& args) {`
`132`	`132`
`133`	`133`	`static void GetFreeMemory(const FunctionCallbackInfo<Value>& args) {`
`134`	`134`	`double amount = uv_get_free_memory();`
`135`		`- if (amount < 0)`
`136`		`- return;`
`137`	`135`	`args.GetReturnValue().Set(amount);`
`138`	`136`	`}`
`139`	`137`
`140`	`138`
`141`	`139`	`static void GetTotalMemory(const FunctionCallbackInfo<Value>& args) {`
`142`	`140`	`double amount = uv_get_total_memory();`
`143`		`- if (amount < 0)`
`144`		`- return;`
`145`	`141`	`args.GetReturnValue().Set(amount);`
`146`	`142`	`}`
`147`	`143`