src: remove unnecessary std::endl usage

danbev · targos · commit f6655b41fa5f · 2019-11-11T10:24:50.000+01:00
This commit removes a few std::endl that could be replaced by '\n' as it does not look like the buffer needs to be flushed in these places. This is only done in error handling, and once when the report has been generated, so this is very minor but I thought I'd bring it up in case it was overlooked. PR-URL: #30003 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
diff --git a/src/node_report.cc b/src/node_report.cc
@@ -110,8 +110,7 @@ std::string TriggerNodeReport(Isolate* isolate,
     }
     // Check for errors on the file open
     if (!outfile.is_open()) {
-      std::cerr << std::endl
-                << "Failed to open Node.js report file: " << filename;
+      std::cerr << "\nFailed to open Node.js report file: " << filename;
 
       if (env != nullptr && options->report_directory.length() > 0)
         std::cerr << " directory: " << options->report_directory;
@@ -120,7 +119,7 @@ std::string TriggerNodeReport(Isolate* isolate,
       return "";
     }
     outstream = &outfile;
-    std::cerr << std::endl << "Writing Node.js report to file: " << filename;
+    std::cerr << "\nWriting Node.js report to file: " << filename;
   }
 
   WriteNodeReport(isolate, env, message, trigger, filename, *outstream,
@@ -131,7 +130,7 @@ std::string TriggerNodeReport(Isolate* isolate,
     outfile.close();
   }
 
-  std::cerr << std::endl << "Node.js report completed" << std::endl;
+  std::cerr << "\nNode.js report completed" << std::endl;
   return filename;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -110,8 +110,7 @@ std::string TriggerNodeReport(Isolate* isolate,`
`110`	`110`	`}`
`111`	`111`	`// Check for errors on the file open`
`112`	`112`	`if (!outfile.is_open()) {`
`113`		`- std::cerr << std::endl`
`114`		`- << "Failed to open Node.js report file: " << filename;`
	`113`	`+ std::cerr << "\nFailed to open Node.js report file: " << filename;`
`115`	`114`
`116`	`115`	`if (env != nullptr && options->report_directory.length() > 0)`
`117`	`116`	`std::cerr << " directory: " << options->report_directory;`
`@@ -120,7 +119,7 @@ std::string TriggerNodeReport(Isolate* isolate,`
`120`	`119`	`return "";`
`121`	`120`	`}`
`122`	`121`	`outstream = &outfile;`
`123`		`- std::cerr << std::endl << "Writing Node.js report to file: " << filename;`
	`122`	`+ std::cerr << "\nWriting Node.js report to file: " << filename;`
`124`	`123`	`}`
`125`	`124`
`126`	`125`	`WriteNodeReport(isolate, env, message, trigger, filename, *outstream,`
`@@ -131,7 +130,7 @@ std::string TriggerNodeReport(Isolate* isolate,`
`131`	`130`	`outfile.close();`
`132`	`131`	`}`
`133`	`132`
`134`		`- std::cerr << std::endl << "Node.js report completed" << std::endl;`
	`133`	`+ std::cerr << "\nNode.js report completed" << std::endl;`
`135`	`134`	`return filename;`
`136`	`135`	`}`
`137`	`136`