test: improve assertion in test-inspector.js

Trott · MylesBorins · commit f2158f30fbf0 · 2018-09-25T16:45:48.000-04:00
Remove an unecessary string literal from assert.strictEqual() call in test-inspector.js. The string literal is printed instead of the value that causes an error. Removing the string literal allows the value that caused the error to be printed. This improves the troubleshooting experience when the test fails due to that assertion. Backport-PR-URL: #22888 PR-URL: #22849 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/test/sequential/test-inspector.js b/test/sequential/test-inspector.js
@@ -33,8 +33,7 @@ function checkBadPath(err) {
 }
 
 function checkException(message) {
-  assert.strictEqual(message.exceptionDetails, undefined,
-                     'An exception occurred during execution');
+  assert.strictEqual(message.exceptionDetails, undefined);
 }
 
 function assertNoUrlsWhileConnected(response) {

Original file line number	Diff line number	Diff line change
`@@ -33,8 +33,7 @@ function checkBadPath(err) {`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`function checkException(message) {`
`36`		`- assert.strictEqual(message.exceptionDetails, undefined,`
`37`		`- 'An exception occurred during execution');`
	`36`	`+ assert.strictEqual(message.exceptionDetails, undefined);`
`38`	`37`	`}`
`39`	`38`
`40`	`39`	`function assertNoUrlsWhileConnected(response) {`