benchmark: use let instead of var in util

dnlup · addaleax · commit f1d3fb067bcd · 2020-03-30T19:18:35.000+02:00
PR-URL: #31794 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/benchmark/util/inspect-array.js b/benchmark/util/inspect-array.js
@@ -15,8 +15,8 @@ const bench = common.createBenchmark(main, {
 });
 
 function main({ n, len, type }) {
-  var arr = Array(len);
-  var i, opts;
+  let arr = Array(len);
+  let opts;
 
   switch (type) {
     case 'denseArray_showHidden':
@@ -29,14 +29,14 @@ function main({ n, len, type }) {
     case 'sparseArray':
       break;
     case 'mixedArray':
-      for (i = 0; i < n; i += 2)
+      for (let i = 0; i < n; i += 2)
         arr[i] = i;
       break;
     default:
       throw new Error(`Unsupported type ${type}`);
   }
   bench.start();
-  for (i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     util.inspect(arr, opts);
   }
   bench.end(n);
diff --git a/benchmark/util/inspect.js b/benchmark/util/inspect.js
@@ -37,7 +37,7 @@ function benchmark(n, obj, options) {
 }
 
 function main({ method, n, option }) {
-  var obj;
+  let obj;
   const options = opts[option];
   switch (method) {
     case 'Object':
diff --git a/benchmark/util/normalize-encoding.js b/benchmark/util/normalize-encoding.js
@@ -46,11 +46,11 @@ function getInput(input) {
 function main({ input, n }) {
   const { normalizeEncoding } = require('internal/util');
   const inputs = getInput(input);
-  var noDead = '';
+  let noDead = '';
 
   bench.start();
-  for (var i = 0; i < n; ++i) {
-    for (var j = 0; j < inputs.length; ++j) {
+  for (let i = 0; i < n; ++i) {
+    for (let j = 0; j < inputs.length; ++j) {
       noDead = normalizeEncoding(inputs[j]);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ function benchmark(n, obj, options) {`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`function main({ method, n, option }) {`
`40`		`- var obj;`
	`40`	`+ let obj;`
`41`	`41`	`const options = opts[option];`
`42`	`42`	`switch (method) {`
`43`	`43`	`case 'Object':`
Original file line number	Diff line number	Diff line change
`@@ -46,11 +46,11 @@ function getInput(input) {`
`46`	`46`	`function main({ input, n }) {`
`47`	`47`	`const { normalizeEncoding } = require('internal/util');`
`48`	`48`	`const inputs = getInput(input);`
`49`		`- var noDead = '';`
	`49`	`+ let noDead = '';`
`50`	`50`
`51`	`51`	`bench.start();`
`52`		`- for (var i = 0; i < n; ++i) {`
`53`		`- for (var j = 0; j < inputs.length; ++j) {`
	`52`	`+ for (let i = 0; i < n; ++i) {`
	`53`	`+ for (let j = 0; j < inputs.length; ++j) {`
`54`	`54`	`noDead = normalizeEncoding(inputs[j]);`
`55`	`55`	`}`
`56`	`56`	`}`