src: use DCHECK in AsyncWrap::MakeCallback instead emiting a warning

Flarna · aduh95 · commit ef7ffce7cf44 · 2026-05-07T15:41:43.000+02:00
Replace emitting of a process warning by a DCHECK because the use after free in http parser is fixed now. Refs: #61995 (comment) Refs: #62095 PR-URL: #62795 Refs: #62095 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
diff --git a/src/async_wrap.cc b/src/async_wrap.cc
@@ -25,9 +25,6 @@
 #include "env-inl.h"
 #include "node_errors.h"
 #include "node_external_reference.h"
-#ifdef DEBUG
-#include <node_process-inl.h>
-#endif
 #include "tracing/traced_value.h"
 #include "util-inl.h"
 
@@ -677,13 +674,8 @@ MaybeLocal<Value> AsyncWrap::MakeCallback(const Local<Function> cb,
                                           Local<Value>* argv) {
   EmitTraceEventBefore();
 
-#ifdef DEBUG
-  if (context_frame().IsEmpty()) {
-    ProcessEmitWarning(env(),
-                       "MakeCallback() called without context_frame, "
-                       "likely use after destroy of AsyncWrap.");
-  }
-#endif
+  // If this check fails it indicates an use after-free.
+  DCHECK(!context_frame().IsEmpty());
 
   ProviderType provider = provider_type();
   async_context context { get_async_id(), get_trigger_async_id() };
