dns: honor the order option

lpinca · ruyadorno · commit ef6707eb9bac · 2024-11-27T01:37:53.000-05:00
Fixes: #55391 PR-URL: #55392 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Feng Yu <F3n67u@outlook.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
diff --git a/lib/dns.js b/lib/dns.js
@@ -193,7 +193,7 @@ function lookup(hostname, options, callback) {
     }
     if (options?.order != null) {
       validateOneOf(options.order, 'options.order', ['ipv4first', 'ipv6first', 'verbatim']);
-      dnsOrder = options.dnsOrder;
+      dnsOrder = options.order;
     }
   }
 
diff --git a/test/parallel/test-dns-default-order-verbatim.js b/test/parallel/test-dns-default-order-verbatim.js
@@ -46,4 +46,14 @@ function allowFailed(fn) {
 
   await allowFailed(dnsPromises.lookup('example.org', {}));
   checkParameter(cares.DNS_ORDER_VERBATIM);
+
+  await allowFailed(
+    promisify(dns.lookup)('example.org', { order: 'ipv4first' })
+  );
+  checkParameter(cares.DNS_ORDER_IPV4_FIRST);
+
+  await allowFailed(
+    promisify(dns.lookup)('example.org', { order: 'ipv6first' })
+  );
+  checkParameter(cares.DNS_ORDER_IPV6_FIRST);
 })().then(common.mustCall());

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ function lookup(hostname, options, callback) {`
`193`	`193`	`}`
`194`	`194`	`if (options?.order != null) {`
`195`	`195`	`validateOneOf(options.order, 'options.order', ['ipv4first', 'ipv6first', 'verbatim']);`
`196`		`- dnsOrder = options.dnsOrder;`
	`196`	`+ dnsOrder = options.order;`
`197`	`197`	`}`
`198`	`198`	`}`
`199`	`199`