src: remove unprofessional slang in assertions

aqrln · gibfahn · commit e90c83638709 · 2017-12-19T20:52:13.000Z
Convert `CHECK(0 && "wtf?")` (sic) assertions to more suitable `UNREACHABLE()` macro invocations in `node_zlib.cc`. PR-URL: #17166 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
diff --git a/src/node_zlib.cc b/src/node_zlib.cc
@@ -336,7 +336,7 @@ class ZCtx : public AsyncWrap {
         }
         break;
       default:
-        CHECK(0 && "wtf?");
+        UNREACHABLE();
     }
 
     // pass any errors back to the main thread to deal with.
@@ -547,7 +547,7 @@ class ZCtx : public AsyncWrap {
             ->AdjustAmountOfExternalAllocatedMemory(kInflateContextSize);
         break;
       default:
-        CHECK(0 && "wtf?");
+        UNREACHABLE();
     }
 
     ctx->dictionary_ = reinterpret_cast<Bytef *>(dictionary);

Original file line number	Diff line number	Diff line change
`@@ -336,7 +336,7 @@ class ZCtx : public AsyncWrap {`
`336`	`336`	`}`
`337`	`337`	`break;`
`338`	`338`	`default:`
`339`		`- CHECK(0 && "wtf?");`
	`339`	`+ UNREACHABLE();`
`340`	`340`	`}`
`341`	`341`
`342`	`342`	`// pass any errors back to the main thread to deal with.`
`@@ -547,7 +547,7 @@ class ZCtx : public AsyncWrap {`
`547`	`547`	`->AdjustAmountOfExternalAllocatedMemory(kInflateContextSize);`
`548`	`548`	`break;`
`549`	`549`	`default:`
`550`		`- CHECK(0 && "wtf?");`
	`550`	`+ UNREACHABLE();`
`551`	`551`	`}`
`552`	`552`
`553`	`553`	`ctx->dictionary_ = reinterpret_cast<Bytef *>(dictionary);`