crypto: remove unneeded guard

Trott · danielleadams · commit e8c66f92a563 · 2022-07-25T21:43:39.000-04:00
createCFRGRaw() will always return an object. The error for an undefined return value will never occur. PR-URL: #43856 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/crypto/cfrg.js b/lib/internal/crypto/cfrg.js
@@ -291,8 +291,6 @@ async function cfrgImportKey(
     case 'raw': {
       verifyAcceptableCfrgKeyUse(name, 'public', usagesSet);
       keyObject = createCFRGRawKey(name, keyData, true);
-      if (keyObject === undefined)
-        throw lazyDOMException('Unable to import CFRG key', 'OperationError');
       break;
     }
   }
diff --git a/lib/internal/crypto/keys.js b/lib/internal/crypto/keys.js
@@ -85,7 +85,7 @@ for (const m of [[kKeyEncodingPKCS1, 'pkcs1'], [kKeyEncodingPKCS8, 'pkcs8'],
   encodingNames[m[0]] = m[1];
 
 // Creating the KeyObject class is a little complicated due to inheritance
-// and that fact that KeyObjects should be transferrable between threads,
+// and the fact that KeyObjects should be transferrable between threads,
 // which requires the KeyObject base class to be implemented in C++.
 // The creation requires a callback to make sure that the NativeKeyObject
 // base class cannot exist without the other KeyObject implementations.

Original file line number	Diff line number	Diff line change
`@@ -291,8 +291,6 @@ async function cfrgImportKey(`
`291`	`291`	`case 'raw': {`
`292`	`292`	`verifyAcceptableCfrgKeyUse(name, 'public', usagesSet);`
`293`	`293`	`keyObject = createCFRGRawKey(name, keyData, true);`
`294`		`- if (keyObject === undefined)`
`295`		`- throw lazyDOMException('Unable to import CFRG key', 'OperationError');`
`296`	`294`	`break;`
`297`	`295`	`}`
`298`	`296`	`}`