zlib: fix crash when initializing failed

addaleax · MylesBorins · commit e79c054f76b8 · 2017-08-11T20:11:04.000-04:00
Unset `mode_` when initializing the zlib stream failed, so that we don’t try to call the zlib end functions (`deflateEnd()` etc.) when cleaning up in `ZCtx::Close()`. Fixes: #14178 Ref: #13098 PR-URL: #14666 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
diff --git a/src/node_zlib.cc b/src/node_zlib.cc
@@ -541,6 +541,7 @@ class ZCtx : public AsyncWrap {
         delete[] dictionary;
         ctx->dictionary_ = nullptr;
       }
+      ctx->mode_ = NONE;
       ctx->env()->ThrowError("Init error");
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -541,6 +541,7 @@ class ZCtx : public AsyncWrap {`
`541`	`541`	`delete[] dictionary;`
`542`	`542`	`ctx->dictionary_ = nullptr;`
`543`	`543`	`}`
	`544`	`+ ctx->mode_ = NONE;`
`544`	`545`	`ctx->env()->ThrowError("Init error");`
`545`	`546`	`}`
`546`	`547`	`}`