src: allow --perf-basic-prof-only-functions in NODE_OPTIONS

tomgco · addaleax · commit e6a254880758 · 2019-02-09T00:44:35.000+01:00
PR-URL: #25565 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/doc/api/cli.md b/doc/api/cli.md
@@ -712,6 +712,7 @@ V8 options that are allowed are:
 - `--abort-on-uncaught-exception`
 - `--max-old-space-size`
 - `--perf-basic-prof`
+- `--perf-basic-prof-only-functions`
 - `--perf-prof`
 - `--stack-trace-limit`
 
diff --git a/src/node_options.cc b/src/node_options.cc
@@ -299,6 +299,10 @@ PerIsolateOptionsParser::PerIsolateOptionsParser() {
             kAllowedInEnvironment);
   AddOption("--max-old-space-size", "", V8Option{}, kAllowedInEnvironment);
   AddOption("--perf-basic-prof", "", V8Option{}, kAllowedInEnvironment);
+  AddOption("--perf-basic-prof-only-functions",
+            "",
+            V8Option{},
+            kAllowedInEnvironment);
   AddOption("--perf-prof", "", V8Option{}, kAllowedInEnvironment);
   AddOption("--stack-trace-limit", "", V8Option{}, kAllowedInEnvironment);
 
diff --git a/test/parallel/test-cli-node-options.js b/test/parallel/test-cli-node-options.js
@@ -38,6 +38,7 @@ expect('--trace-event-file-pattern {pid}-${rotation}.trace_events ' +
 
 if (!common.isWindows) {
   expect('--perf-basic-prof', 'B\n');
+  expect('--perf-basic-prof-only-functions', 'B\n');
 }
 
 if (common.isLinux && ['arm', 'x64'].includes(process.arch)) {

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,7 @@ expect('--trace-event-file-pattern {pid}-${rotation}.trace_events ' +`
`38`	`38`
`39`	`39`	`if (!common.isWindows) {`
`40`	`40`	`expect('--perf-basic-prof', 'B\n');`
	`41`	`+ expect('--perf-basic-prof-only-functions', 'B\n');`
`41`	`42`	`}`
`42`	`43`
`43`	`44`	`if (common.isLinux && ['arm', 'x64'].includes(process.arch)) {`