http: don't emit 'data' after 'error'

ronag · Trott · commit e573c39b889d · 2019-09-22T18:08:20.000-07:00
PR-URL: #28711 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/_http_client.js b/lib/_http_client.js
@@ -406,9 +406,6 @@ function socketErrorListener(err) {
     req.emit('error', err);
   }
 
-  // Handle any pending data
-  socket.read();
-
   const parser = socket.parser;
   if (parser) {
     parser.finish();
diff --git a/test/parallel/test-http-client-read-in-error.js b/test/parallel/test-http-client-read-in-error.js
@@ -1,5 +1,5 @@
 'use strict';
-require('../common');
+const common = require('../common');
 const net = require('net');
 const http = require('http');
 
@@ -37,4 +37,5 @@ http.request({
   agent
 }).once('error', function() {
   console.log('ignore');
+  this.on('data', common.mustNotCall());
 });

Original file line number	Diff line number	Diff line change
`@@ -406,9 +406,6 @@ function socketErrorListener(err) {`
`406`	`406`	`req.emit('error', err);`
`407`	`407`	`}`
`408`	`408`
`409`		`- // Handle any pending data`
`410`		`- socket.read();`
`411`		`-`
`412`	`409`	`const parser = socket.parser;`
`413`	`410`	`if (parser) {`
`414`	`411`	`parser.finish();`