build: update binary-upload to use correct tarball name · nodejs/node@e2e5c4f · GitHub
Skip to content

Commit e2e5c4f

Browse files
committed
build: update binary-upload to use correct tarball name
the binary-upload target uses $(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz as the name to upload whereas it is created by the $(BINARYTAR) target as $(BINARYNAME). Since BINARYNAME includes the optional VARIATION when present this gets missed out int he binary-upload target, for example during a release build for Alpine/musl. This commit changes the binary-upload target to use the same variable for the tarball that is used when the file is created. Signed-off-by: Stewart X Addison <sxa@ibm.com> PR-URL: #65282 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 9e39360 commit e2e5c4f

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

Makefile

Lines changed: 8 additions & 8 deletions

0 commit comments

Comments
 (0)