src: remove unnecessary 'Local.As' operation

himself65 · addaleax · commit e2b08f0ea867 · 2020-03-30T19:18:55.000+02:00
PR-URL: #32286 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node_env_var.cc b/src/node_env_var.cc
@@ -286,7 +286,7 @@ Maybe<bool> KVStore::AssignFromObject(Local<Context> context,
 
     Local<Value> value;
     Local<String> value_string;
-    if (!entries->Get(context, key.As<String>()).ToLocal(&value) ||
+    if (!entries->Get(context, key).ToLocal(&value) ||
         !value->ToString(context).ToLocal(&value_string)) {
       return Nothing<bool>();
     }

Original file line number	Diff line number	Diff line change
`@@ -286,7 +286,7 @@ Maybe<bool> KVStore::AssignFromObject(Local<Context> context,`
`286`	`286`
`287`	`287`	`Local<Value> value;`
`288`	`288`	`Local<String> value_string;`
`289`		`- if (!entries->Get(context, key.As<String>()).ToLocal(&value) \|\|`
	`289`	`+ if (!entries->Get(context, key).ToLocal(&value) \|\|`
`290`	`290`	`!value->ToString(context).ToLocal(&value_string)) {`
`291`	`291`	`return Nothing<bool>();`
`292`	`292`	`}`