src: reuse cached strings in CompileSerializeMain · nodejs/node@e260fd1 · GitHub
Skip to content

Commit e260fd1

Browse files
agape1225aduh95
authored andcommitted
src: reuse cached strings in CompileSerializeMain
CompileSerializeMain() created new "require", "__filename", and "__dirname" strings via FIXED_ONE_BYTE_STRING() on every call, even though these strings are already cached on IsolateData/Environment as require_string(), __filename_string(), and __dirname_string() (defined via PER_ISOLATE_STRING_PROPERTIES in src/env_properties.h) and are reused this way elsewhere (e.g. the sibling RunEmbedderPreload() already obtains Environment* the same way). Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com> PR-URL: #65453 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent b5f0558 commit e260fd1

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

‎src/node_snapshotable.cc‎

Lines changed: 7 additions & 7 deletions

0 commit comments

Comments
 (0)