src: enhance error messages for unknown options

pmarchini · targos · commit dfb0144490a9 · 2025-06-16T08:51:14.000+02:00
PR-URL: #58677 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node_config_file.cc b/src/node_config_file.cc
@@ -200,7 +200,7 @@ ParseResult ConfigReader::ParseOptions(
     } else {
       FPrintF(stderr,
               "Unknown or not allowed option %s for namespace %s\n",
-              option_key.data(),
+              option_key,
               namespace_name.c_str());
       return ParseResult::InvalidContent;
     }
diff --git a/test/parallel/test-config-file.js b/test/parallel/test-config-file.js
@@ -154,7 +154,7 @@ test('should throw at unknown flag', async () => {
     fixtures.path('rc/unknown-flag.json'),
     '-p', '"Hello, World!"',
   ]);
-  match(result.stderr, /Unknown or not allowed option some-unknown-flag/);
+  match(result.stderr, /Unknown or not allowed option some-unknown-flag for namespace nodeOptions/);
   strictEqual(result.stdout, '');
   strictEqual(result.code, 9);
 });
@@ -166,7 +166,7 @@ test('should throw at flag not available in NODE_OPTIONS', async () => {
     fixtures.path('rc/not-node-options-flag.json'),
     '-p', '"Hello, World!"',
   ]);
-  match(result.stderr, /Unknown or not allowed option test/);
+  match(result.stderr, /Unknown or not allowed option test for namespace nodeOptions/);
   strictEqual(result.stdout, '');
   strictEqual(result.code, 9);
 });
@@ -401,7 +401,7 @@ describe('namespace-scoped options', () => {
       fixtures.path('rc/unknown-flag-namespace.json'),
       '-p', '"Hello, World!"',
     ]);
-    match(result.stderr, /Unknown or not allowed option unknown-flag/);
+    match(result.stderr, /Unknown or not allowed option unknown-flag for namespace testRunner/);
     strictEqual(result.stdout, '');
     strictEqual(result.code, 9);
   });

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ ParseResult ConfigReader::ParseOptions(`
`200`	`200`	`} else {`
`201`	`201`	`FPrintF(stderr,`
`202`	`202`	`"Unknown or not allowed option %s for namespace %s\n",`
`203`		`- option_key.data(),`
	`203`	`+ option_key,`
`204`	`204`	`namespace_name.c_str());`
`205`	`205`	`return ParseResult::InvalidContent;`
`206`	`206`	`}`