test: remove uses of common.PORT in test-tls-client tests

z0al · evanlucas · commit ddc35282c020 · 2017-05-02T12:46:14.000-05:00
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error if another test in 'parallel' uses port '0' at the same time. PR-URL: #12461 Ref: #12376 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
diff --git a/test/parallel/test-tls-client-abort.js b/test/parallel/test-tls-client-abort.js
@@ -14,7 +14,7 @@ const path = require('path');
 const cert = fs.readFileSync(path.join(common.fixturesDir, 'test_cert.pem'));
 const key = fs.readFileSync(path.join(common.fixturesDir, 'test_key.pem'));
 
-const conn = tls.connect({cert, key, port: common.PORT}, common.mustNotCall());
+const conn = tls.connect({cert, key, port: 0}, common.mustNotCall());
 conn.on('error', function() {
 });
 assert.doesNotThrow(function() {
diff --git a/test/parallel/test-tls-client-abort2.js b/test/parallel/test-tls-client-abort2.js
@@ -8,7 +8,7 @@ if (!common.hasCrypto) {
 }
 const tls = require('tls');
 
-const conn = tls.connect(common.PORT, common.mustNotCall());
+const conn = tls.connect(0, common.mustNotCall());
 conn.on('error', common.mustCall(function() {
   assert.doesNotThrow(function() {
     conn.destroy();

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ if (!common.hasCrypto) {`
`8`	`8`	`}`
`9`	`9`	`const tls = require('tls');`
`10`	`10`
`11`		`-const conn = tls.connect(common.PORT, common.mustNotCall());`
	`11`	`+const conn = tls.connect(0, common.mustNotCall());`
`12`	`12`	`conn.on('error', common.mustCall(function() {`
`13`	`13`	`assert.doesNotThrow(function() {`
`14`	`14`	`conn.destroy();`