process: improve performance of nextTick

evanlucas · MylesBorins · commit db10e940833d · 2016-12-21T13:13:21.000-05:00
This replaces TickObject with an object literal. This offers performance improvements of up to ~20%. PR-URL: #8932 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
diff --git a/lib/internal/process/next_tick.js b/lib/internal/process/next_tick.js
@@ -131,12 +131,6 @@ function setupNextTick() {
     } while (tickInfo[kLength] !== 0);
   }
 
-  function TickObject(c, args) {
-    this.callback = c;
-    this.domain = process.domain || null;
-    this.args = args;
-  }
-
   function nextTick(callback) {
     if (typeof callback !== 'function')
       throw new TypeError('callback is not a function');
@@ -151,7 +145,11 @@ function setupNextTick() {
         args[i - 1] = arguments[i];
     }
 
-    nextTickQueue.push(new TickObject(callback, args));
+    nextTickQueue.push({
+      callback,
+      domain: process.domain || null,
+      args
+    });
     tickInfo[kLength]++;
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -131,12 +131,6 @@ function setupNextTick() {`
`131`	`131`	`} while (tickInfo[kLength] !== 0);`
`132`	`132`	`}`
`133`	`133`
`134`		`- function TickObject(c, args) {`
`135`		`- this.callback = c;`
`136`		`- this.domain = process.domain \|\| null;`
`137`		`- this.args = args;`
`138`		`- }`
`139`		`-`
`140`	`134`	`function nextTick(callback) {`
`141`	`135`	`if (typeof callback !== 'function')`
`142`	`136`	`throw new TypeError('callback is not a function');`
`@@ -151,7 +145,11 @@ function setupNextTick() {`
`151`	`145`	`args[i - 1] = arguments[i];`
`152`	`146`	`}`
`153`	`147`
`154`		`- nextTickQueue.push(new TickObject(callback, args));`
	`148`	`+ nextTickQueue.push({`
	`149`	`+ callback,`
	`150`	`+ domain: process.domain \|\| null,`
	`151`	`+ args`
	`152`	`+ });`
`155`	`153`	`tickInfo[kLength]++;`
`156`	`154`	`}`
`157`	`155`	`}`