tls: use validateFunction for options.SNICallback

deokjinkim · UlisesGascon · commit d905c61e163e · 2023-12-11T17:50:26.000Z
If user uses invalid type for `options.SNICallback` in TLSSocket(), it's not internal issue of Node.js. So validateFunction() is more proper than assert(). PR-URL: #50530 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
@@ -909,7 +909,7 @@ TLSSocket.prototype._init = function(socket, wrap) {
       options.SNICallback &&
       (options.SNICallback !== SNICallback ||
        (options.server && options.server._contexts.length))) {
-    assert(typeof options.SNICallback === 'function');
+    validateFunction(options.SNICallback, 'options.SNICallback');
     this._SNICallback = options.SNICallback;
     ssl.enableCertCb();
   }
diff --git a/test/parallel/test-tls-snicallback-error.js b/test/parallel/test-tls-snicallback-error.js
@@ -4,11 +4,21 @@ if (!common.hasCrypto)
   common.skip('missing crypto');
 
 const assert = require('assert');
+const net = require('net');
 const tls = require('tls');
 
-['fhqwhgads', 42, {}, []].forEach((testValue) => {
-  assert.throws(
-    () => { tls.createServer({ SNICallback: testValue }); },
-    { code: 'ERR_INVALID_ARG_TYPE', message: /\boptions\.SNICallback\b/ }
-  );
-});
+for (const SNICallback of ['fhqwhgads', 42, {}, []]) {
+  assert.throws(() => {
+    tls.createServer({ SNICallback });
+  }, {
+    code: 'ERR_INVALID_ARG_TYPE',
+    name: 'TypeError',
+  });
+
+  assert.throws(() => {
+    new tls.TLSSocket(new net.Socket(), { isServer: true, SNICallback });
+  }, {
+    code: 'ERR_INVALID_ARG_TYPE',
+    name: 'TypeError',
+  });
+}

Original file line number	Diff line number	Diff line change
`@@ -909,7 +909,7 @@ TLSSocket.prototype._init = function(socket, wrap) {`
`909`	`909`	`options.SNICallback &&`
`910`	`910`	`(options.SNICallback !== SNICallback \|\|`
`911`	`911`	`(options.server && options.server._contexts.length))) {`
`912`		`- assert(typeof options.SNICallback === 'function');`
	`912`	`+ validateFunction(options.SNICallback, 'options.SNICallback');`
`913`	`913`	`this._SNICallback = options.SNICallback;`
`914`	`914`	`ssl.enableCertCb();`
`915`	`915`	`}`