src: fix unused private field warning

cjihrig · BridgeAR · commit d81c67bd8f72 · 2019-06-17T19:49:43.000+02:00
PR-URL: #28036 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/src/inspector/runtime_agent.cc b/src/inspector/runtime_agent.cc
@@ -7,8 +7,8 @@ namespace node {
 namespace inspector {
 namespace protocol {
 
-RuntimeAgent::RuntimeAgent(Environment* env)
-  : notify_when_waiting_for_disconnect_(false), env_(env) {}
+RuntimeAgent::RuntimeAgent()
+  : notify_when_waiting_for_disconnect_(false) {}
 
 void RuntimeAgent::Wire(UberDispatcher* dispatcher) {
   frontend_ = std::make_unique<NodeRuntime::Frontend>(dispatcher->channel());
diff --git a/src/inspector/runtime_agent.h b/src/inspector/runtime_agent.h
@@ -12,7 +12,7 @@ namespace protocol {
 
 class RuntimeAgent : public NodeRuntime::Backend {
  public:
-  explicit RuntimeAgent(Environment* env);
+  RuntimeAgent();
 
   void Wire(UberDispatcher* dispatcher);
 
@@ -23,7 +23,6 @@ class RuntimeAgent : public NodeRuntime::Backend {
  private:
   std::shared_ptr<NodeRuntime::Frontend> frontend_;
   bool notify_when_waiting_for_disconnect_;
-  Environment* env_;
 };
 }  // namespace protocol
 }  // namespace inspector
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc
@@ -239,7 +239,7 @@ class ChannelImpl final : public v8_inspector::V8Inspector::Channel,
     tracing_agent_->Wire(node_dispatcher_.get());
     worker_agent_ = std::make_unique<protocol::WorkerAgent>(worker_manager);
     worker_agent_->Wire(node_dispatcher_.get());
-    runtime_agent_ = std::make_unique<protocol::RuntimeAgent>(env);
+    runtime_agent_ = std::make_unique<protocol::RuntimeAgent>();
     runtime_agent_->Wire(node_dispatcher_.get());
   }
 

Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ class ChannelImpl final : public v8_inspector::V8Inspector::Channel,`
`239`	`239`	`tracing_agent_->Wire(node_dispatcher_.get());`
`240`	`240`	`worker_agent_ = std::make_unique<protocol::WorkerAgent>(worker_manager);`
`241`	`241`	`worker_agent_->Wire(node_dispatcher_.get());`
`242`		`- runtime_agent_ = std::make_unique<protocol::RuntimeAgent>(env);`
	`242`	`+ runtime_agent_ = std::make_unique<protocol::RuntimeAgent>();`
`243`	`243`	`runtime_agent_->Wire(node_dispatcher_.get());`
`244`	`244`	`}`
`245`	`245`