build: fix MSVC 2022 Release compilation · nodejs/node@d795d93 · GitHub
Skip to content

Commit d795d93

Browse files
vmorozruyadorno
vmoroz
authored and
ruyadorno
committed
build: fix MSVC 2022 Release compilation
PR-URL: #46228 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent 813b160 commit d795d93

4 files changed

Lines changed: 20 additions & 2 deletions

File tree

‎.github/workflows/build-windows.yml‎

Lines changed: 1 addition & 1 deletion

‎.github/workflows/coverage-windows.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ permissions:
3737
jobs:
3838
coverage-windows:
3939
if: github.event.pull_request.draft == false
40-
runs-on: windows-2019
40+
runs-on: windows-2022
4141
steps:
4242
- uses: actions/checkout@v3
4343
with:

‎tools/v8_gypfiles/directory.build.props‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<Project>
3+
<ItemDefinitionGroup>
4+
<MARMASM>
5+
<!-- Works around a situation when we preprocess file in $(IntDir). In such case the output file is the same as input file
6+
and we get access violation. Appending '.pp' file extension to the output file name resolves this issue. -->
7+
<PreprocessedFileName Condition="'%(PreprocessedFileName)' == ''">$(IntDir)%(FileName)%(Extension).pp</PreprocessedFileName>
8+
</MARMASM>
9+
</ItemDefinitionGroup>
10+
</Project>

‎tools/v8_gypfiles/v8.gyp‎

Lines changed: 8 additions & 0 deletions

0 commit comments

Comments
 (0)