v8: replace Buffer with FastBuffer in deserialize

ryzokuken · targos · commit d46446afc519 · 2018-06-14T20:34:52.000+02:00
Replace the Buffer constructor with a FastBuffer in v8.deserialize in order to avoid calling the Buffer constructor and thus triggering a deprecation warning from code inside the core. Fixes: #21181 PR-URL: #21196 Fixes: #21181 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/v8.js b/lib/v8.js
@@ -143,7 +143,7 @@ const arrayBufferViewTypeToIndex = new Map();
   }
 }
 
-const bufferConstructorIndex = arrayBufferViewTypes.push(Buffer) - 1;
+const bufferConstructorIndex = arrayBufferViewTypes.push(FastBuffer) - 1;
 
 class DefaultSerializer extends Serializer {
   constructor() {
diff --git a/test/parallel/test-v8-deserialize-buffer.js b/test/parallel/test-v8-deserialize-buffer.js
@@ -0,0 +1,8 @@
+// Flags: --pending-deprecation --no-warnings
+'use strict';
+
+const common = require('../common');
+const v8 = require('v8');
+
+process.on('warning', common.mustNotCall());
+v8.deserialize(v8.serialize(Buffer.alloc(0)));

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ const arrayBufferViewTypeToIndex = new Map();`
`143`	`143`	`}`
`144`	`144`	`}`
`145`	`145`
`146`		`-const bufferConstructorIndex = arrayBufferViewTypes.push(Buffer) - 1;`
	`146`	`+const bufferConstructorIndex = arrayBufferViewTypes.push(FastBuffer) - 1;`
`147`	`147`
`148`	`148`	`class DefaultSerializer extends Serializer {`
`149`	`149`	`constructor() {`