inspector: allow opening inspector when NODE_V8_COVERAGE is set

MoLow · ruyadorno · commit d4370259e9bb · 2023-01-31T18:18:10.000-05:00
PR-URL: #46113 Fixes: #46110 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/inspector_js_api.cc b/src/inspector_js_api.cc
@@ -273,7 +273,7 @@ static void RegisterAsyncHookWrapper(const FunctionCallbackInfo<Value>& args) {
 
 void IsEnabled(const FunctionCallbackInfo<Value>& args) {
   Environment* env = Environment::GetCurrent(args);
-  args.GetReturnValue().Set(InspectorEnabled(env));
+  args.GetReturnValue().Set(env->inspector_agent()->IsListening());
 }
 
 void Open(const FunctionCallbackInfo<Value>& args) {
diff --git a/test/fixtures/inspector-open.js b/test/fixtures/inspector-open.js
@@ -0,0 +1,14 @@
+const assert = require('assert');
+const inspector = require('inspector');
+
+
+assert.strictEqual(inspector.url(), undefined);
+inspector.open(0, undefined, false);
+assert(inspector.url().startsWith('ws://'));
+assert.throws(() => {
+  inspector.open(0, undefined, false);
+}, {
+  code: 'ERR_INSPECTOR_ALREADY_ACTIVATED'
+});
+inspector.close();
+assert.strictEqual(inspector.url(), undefined);
diff --git a/test/parallel/test-inspector-open-coverage.js b/test/parallel/test-inspector-open-coverage.js
@@ -0,0 +1,21 @@
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+const { spawnSync } = require('child_process');
+const fixtures = require('../common/fixtures');
+const tmpdir = require('../common/tmpdir');
+
+common.skipIfInspectorDisabled();
+common.skipIfWorker();
+
+tmpdir.refresh();
+
+
+let output = spawnSync(process.execPath, [fixtures.path('inspector-open.js')]);
+assert.strictEqual(output.status, 0);
+
+output = spawnSync(process.execPath, [fixtures.path('inspector-open.js')], {
+  env: { ...process.env, NODE_V8_COVERAGE: tmpdir.path },
+});
+assert.strictEqual(output.status, 0);

Original file line number	Diff line number	Diff line change
`@@ -273,7 +273,7 @@ static void RegisterAsyncHookWrapper(const FunctionCallbackInfo<Value>& args) {`
`273`	`273`
`274`	`274`	`void IsEnabled(const FunctionCallbackInfo<Value>& args) {`
`275`	`275`	`Environment* env = Environment::GetCurrent(args);`
`276`		`- args.GetReturnValue().Set(InspectorEnabled(env));`
	`276`	`+ args.GetReturnValue().Set(env->inspector_agent()->IsListening());`
`277`	`277`	`}`
`278`	`278`
`279`	`279`	`void Open(const FunctionCallbackInfo<Value>& args) {`